From cd7b4cbacbc968bd4d7ed5fed9122f75d229793c Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 8 Apr 2014 03:51:02 +0000 Subject: minor cleanups for functions which do not return pthread_exit and abort never returns, so quiet down some warnings when using -Wunreachable-code on clang. Unfortunately using -Wunreachable-code globally is too noisy due to 1) Ragel-generated code. 2) constant branch conditions for build-time options (trace/cork) --- accept_loop.c | 2 +- svc_dev.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/accept_loop.c b/accept_loop.c index b324735..1821305 100644 --- a/accept_loop.c +++ b/accept_loop.c @@ -48,7 +48,7 @@ MOG_NOINLINE static void accept_error_check(struct mog_accept *ac) assert(0 && "BUG, called accept on bad FD"); case ENOTSOCK: case EOPNOTSUPP: - return pthread_exit(NULL); + pthread_exit(NULL); case_EAGAIN: /* * listen socket could've been inherited from another process, diff --git a/svc_dev.c b/svc_dev.c index b6a1e71..bb83128 100644 --- a/svc_dev.c +++ b/svc_dev.c @@ -75,7 +75,6 @@ static struct mog_devlist * svc_devlist(struct mog_svc *svc, dev_t st_dev) assert(0 && "race condition, devlist should insert " "without error"); abort(); - break; case 1: break; /* OK, inserted */ default: mog_oom(); /* -1 */ } -- cgit v1.2.3-24-ge0c7