kcar RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: kcar-public@bogomips.org
Subject: [PATCH 4/5] remove rb_str_modify workaround
Date: Fri,  3 Mar 2017 20:53:06 +0000	[thread overview]
Message-ID: <20170303205307.2275-5-e@80x24.org> (raw)
In-Reply-To: <20170303205307.2275-1-e@80x24.org>

Every supported Ruby implementation has a rb_str_modify
wrapper.
---
 ext/kcar/ext_help.h | 4 ----
 ext/kcar/extconf.rb | 1 -
 2 files changed, 5 deletions(-)

diff --git a/ext/kcar/ext_help.h b/ext/kcar/ext_help.h
index d227737..a0e21e2 100644
--- a/ext/kcar/ext_help.h
+++ b/ext/kcar/ext_help.h
@@ -16,10 +16,6 @@
 #  endif
 #endif /* ! defined(OFFT2NUM) */
 
-#ifndef HAVE_RB_STR_MODIFY
-#  define rb_str_modify(x) do {} while (0)
-#endif /* ! defined(HAVE_RB_STR_MODIFY) */
-
 static inline int str_cstr_eq(VALUE val, const char *ptr, long len)
 {
   return (RSTRING_LEN(val) == len && !memcmp(ptr, RSTRING_PTR(val), len));
diff --git a/ext/kcar/extconf.rb b/ext/kcar/extconf.rb
index 3585125..7ab5b4b 100644
--- a/ext/kcar/extconf.rb
+++ b/ext/kcar/extconf.rb
@@ -5,7 +5,6 @@ dir_config("kcar")
 
 have_macro("SIZEOF_OFF_T", "ruby.h") or check_sizeof("off_t", "sys/types.h")
 have_macro("SIZEOF_LONG", "ruby.h") or check_sizeof("long", "sys/types.h")
-have_func("rb_str_modify", "ruby.h")
 
 # -fPIC is needed for Rubinius, MRI already uses it regardless
 with_cflags($CFLAGS + " -fPIC ") do
-- 
EW


  parent reply	other threads:[~2017-03-03 20:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03 20:53 [PATCH 0/5] miscellaneous updates Eric Wong
2017-03-03 20:53 ` [PATCH 1/5] gemspec: use SPDX compatible terms for the license(s) Eric Wong
2017-03-03 20:53 ` [PATCH 2/5] archive/slrnpull.conf: add a note explaining the purpose Eric Wong
2017-03-03 20:53 ` [PATCH 3/5] drop rb_str_set_len compatibility replacement Eric Wong
2017-03-03 20:53 ` Eric Wong [this message]
2017-03-03 20:53 ` [PATCH 5/5] TypedData C-API conversion Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/kcar/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170303205307.2275-5-e@80x24.org \
    --to=e@80x24.org \
    --cc=kcar-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/kcar.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).