ext: remove dead code from Parser#filter_body

We avoid filter_body overhead for things with known
content-length.

1 files changed, 17 insertions, 30 deletions

diff --git a/ext/kcar/kcar.rl b/ext/kcar/kcar.rl
index 0d22866..8c2b465 100644
--- a/ext/kcar/kcar.rl
+++ b/ext/kcar/kcar.rl
@@ -560,36 +560,23 @@ static VALUE filter_body(VALUE self, VALUE buf, VALUE data)
   rb_str_resize(buf, dlen); /* we can never copy more than dlen bytes */
   OBJ_TAINT(buf); /* keep weirdo $SAFE users happy */
 
-  if (HP_FL_TEST(hp, CHUNKED)) {
-    if (!chunked_eof(hp)) {
-      hp->s.dest_offset = 0;
-      http_parser_execute(hp, buf, dptr, dlen);
-      if (hp->cs == http_parser_error)
-        rb_raise(eParserError, "Invalid HTTP format, parsing fails.");
-
-      assert(hp->s.dest_offset <= hp->offset &&
-             "destination buffer overflow");
-      advance_str(data, hp->offset);
-      rb_str_set_len(buf, hp->s.dest_offset);
-
-      if (RSTRING_LEN(buf) == 0 && chunked_eof(hp)) {
-        assert(hp->len.chunk == 0 && "chunk at EOF but more to parse");
-      } else {
-        data = Qnil;
-      }
-    }
-  } else {
-    /* no need to enter the Ragel machine for unchunked transfers */
-    assert(hp->len.content >= 0 && "negative Content-Length");
-    if (hp->len.content > 0) {
-      long nr = MIN(dlen, hp->len.content);
-
-      memcpy(RSTRING_PTR(buf), dptr, nr);
-      hp->len.content -= nr;
-      if (hp->len.content == 0)
-        hp->cs = http_parser_first_final;
-      advance_str(data, nr);
-      rb_str_set_len(buf, nr);
+  if (!HP_FL_TEST(hp, CHUNKED))
+    rb_raise(rb_eRuntimeError, "filter_body is only for chunked bodies");
+
+  if (!chunked_eof(hp)) {
+    hp->s.dest_offset = 0;
+    http_parser_execute(hp, buf, dptr, dlen);
+    if (hp->cs == http_parser_error)
+      rb_raise(eParserError, "Invalid HTTP format, parsing fails.");
+
+    assert(hp->s.dest_offset <= hp->offset &&
+           "destination buffer overflow");
+    advance_str(data, hp->offset);
+    rb_str_set_len(buf, hp->s.dest_offset);
+
+    if (RSTRING_LEN(buf) == 0 && chunked_eof(hp)) {
+      assert(hp->len.chunk == 0 && "chunk at EOF but more to parse");
+    } else {
       data = Qnil;
     }
   }