* [kgio] [PATCH] Fixed some typos in Kgio::SSLConnector documentation (by Iñaki Baz Castillo <ibc@aliax.ne t>).
@ 2012-04-10 21:45 Iñaki Baz Castillo
2012-04-11 19:48 ` [PATCH] Fixed some typos in Kgio::SSLConnector documentation Eric Wong
0 siblings, 1 reply; 5+ messages in thread
From: Iñaki Baz Castillo @ 2012-04-10 21:45 UTC (permalink / raw)
To: kgio
---
ext/kgio_monkey/kgio_monkey.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ext/kgio_monkey/kgio_monkey.c b/ext/kgio_monkey/kgio_monkey.c
index 75ff5bd..56e8fad 100644
--- a/ext/kgio_monkey/kgio_monkey.c
+++ b/ext/kgio_monkey/kgio_monkey.c
@@ -907,7 +907,7 @@ static VALUE conn_trysendfile(int argc, VALUE *argv, VALUE self)
* call-seq:
* Kgio::SSLConnector.new(io, ssl_ctx, hostname, session = nil)
*
- * Initializes and SSL/TLS client socket. Like Kgio::SSL.new, except
+ * Initializes an SSL/TLS client socket. Like Kgio::SSL.new, except
* +hostname+ is required for verification and +session+ may be specified
* as an OpenSSL::SSL::Session object.
*/
@@ -997,7 +997,7 @@ void Init_kgio_monkey_ext(void)
* Document-class: Kgio::SSLConnector
*
* Like Kgio::SSL, but for SSL/TLS clients that connect to
- * clients, not SSL/TLS servers.
+ * servers, not for SSL/TLS servers.
*/
cConnector = rb_define_class_under(mKgio, "SSLConnector", cKgioSSL);
rb_define_alloc_func(cKgioSSL, ssl_alloc);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Fixed some typos in Kgio::SSLConnector documentation
2012-04-10 21:45 [kgio] [PATCH] Fixed some typos in Kgio::SSLConnector documentation (by Iñaki Baz Castillo <ibc@aliax.ne t>) Iñaki Baz Castillo
@ 2012-04-11 19:48 ` Eric Wong
2012-04-11 20:09 ` Iñaki Baz Castillo
0 siblings, 1 reply; 5+ messages in thread
From: Eric Wong @ 2012-04-11 19:48 UTC (permalink / raw)
To: kgio
Thanks, signed-off and pushed.
(btw, no need to put your name/email in the commit message
title/Subject, the From: header is parsed by "git am".
"git am" will also parse a From: line in the commit message
body in cases where an email sender wants to use a different
email address in the commit message than the email address
they're submitting the patch from.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fixed some typos in Kgio::SSLConnector documentation
2012-04-11 19:48 ` [PATCH] Fixed some typos in Kgio::SSLConnector documentation Eric Wong
@ 2012-04-11 20:09 ` Iñaki Baz Castillo
2012-04-11 20:18 ` Eric Wong
0 siblings, 1 reply; 5+ messages in thread
From: Iñaki Baz Castillo @ 2012-04-11 20:09 UTC (permalink / raw)
To: kgio
2012/4/11 Eric Wong <normalperson@yhbt.net>:
> Thanks, signed-off and pushed.
>
> (btw, no need to put your name/email in the commit message
> title/Subject, the From: header is parsed by "git am".
> "git am" will also parse a From: line in the commit message
> body in cases where an email sender wants to use a different
> email address in the commit message than the email address
> they're submitting the patch from.
Ops, honestly I didn't use "git am" but instead:
git format-patch -1 -o /tmp/kk/
git send-email
/tmp/kk/0001-Fixed-some-typos-in-Kgio-SSLConnector-documentation-.patch
(and some work in ssmtp.conf for sending via Gmail) :)
--
Iñaki Baz Castillo
<ibc@aliax.net>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fixed some typos in Kgio::SSLConnector documentation
2012-04-11 20:09 ` Iñaki Baz Castillo
@ 2012-04-11 20:18 ` Eric Wong
2012-04-11 20:36 ` Iñaki Baz Castillo
0 siblings, 1 reply; 5+ messages in thread
From: Eric Wong @ 2012-04-11 20:18 UTC (permalink / raw)
To: kgio
Iñaki Baz Castillo <ibc@aliax.net> wrote:
> Ops, honestly I didn't use "git am" but instead:
I mean *I* use "git am" to apply the patch on my end :)
("am" is short for "applymbox", git-am replaced the original
git-applymbox script early in git development)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fixed some typos in Kgio::SSLConnector documentation
2012-04-11 20:18 ` Eric Wong
@ 2012-04-11 20:36 ` Iñaki Baz Castillo
0 siblings, 0 replies; 5+ messages in thread
From: Iñaki Baz Castillo @ 2012-04-11 20:36 UTC (permalink / raw)
To: kgio
2012/4/11 Eric Wong <normalperson@yhbt.net>:
> Iñaki Baz Castillo <ibc@aliax.net> wrote:
>> Ops, honestly I didn't use "git am" but instead:
>
> I mean *I* use "git am" to apply the patch on my end :)
>
> ("am" is short for "applymbox", git-am replaced the original
> git-applymbox script early in git development)
Ahh ok ok :)
--
Iñaki Baz Castillo
<ibc@aliax.net>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-04-11 20:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-10 21:45 [kgio] [PATCH] Fixed some typos in Kgio::SSLConnector documentation (by Iñaki Baz Castillo <ibc@aliax.ne t>) Iñaki Baz Castillo
2012-04-11 19:48 ` [PATCH] Fixed some typos in Kgio::SSLConnector documentation Eric Wong
2012-04-11 20:09 ` Iñaki Baz Castillo
2012-04-11 20:18 ` Eric Wong
2012-04-11 20:36 ` Iñaki Baz Castillo
Code repositories for project(s) associated with this public inbox
https://yhbt.net/kgio.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).