Re: Current test failures on OpenBSD

[Jeremy Evans <code@jeremyevans.net>]

On 11/15 03:26, Eric Wong wrote:
> Jeremy Evans <code@jeremyevans.net> wrote:
> >   1) Failure:
> > test_accept_flags(TestAcceptFlags) [test/test_accept_flags.rb:25]:
> > <false> is not true.
> 
> That might be a bad test, is this on MRI 1.8.7 or 1.9.x?
> There's a huge difference in how accept() works between them.

Eric,
 
Sorry for not being more specific earlier.  It only happens on 1.8.7.
The test passes on 1.9.3.

> >   1) Failure:                                                                                                                                         [38/1327]
> > test_blocking_accept_flags(TestKgioUNIXServer) [./test/lib_server_accept.rb:37]:
> > <false> expected but was
> > <true>.
> 
> Looks like the same class of failure for all the accept() tests...

This fails on 1.8.7 and passes on 1.9.3 on OpenBSD.

> kgio also attempts to allow the same listen socket to be shared
> between a 1.8.7 and 1.9.2 process during accept()
> 
> >   2) Failure:
> > test_tryaccept_flags(TestKgioUNIXServer) [./test/lib_server_accept.rb:28]:
> > <false> expected but was
> > <true>.

This fails on 1.8.7 and 1.9.3 on OpenBSD.

> >   1) Failure:
> > test_blocking_accept_flags(TestKgioTCPServer) [./test/lib_server_accept.rb:37]:
> > <false> expected but was
> > <true>.

This fails on 1.8.7 and passes on 1.9.3 on OpenBSD.

> >   2) Failure:
> > test_tryaccept_flags(TestKgioTCPServer) [./test/lib_server_accept.rb:28]:
> > <false> expected but was
> > <true>.

This fails on 1.8.7 and 1.9.3 on OpenBSD.

Should the 5 accept tests that fail on 1.8.7 just be skipped?

It looks like the tryaccept flag isn't supported on OpenBSD, or at least
that it doesn't set the returned socket to nonblocking.  Should those tests
be skipped on OpenBSD, or could there a bug in the code?

Thanks for your help,
Jeremy