Re: There's no TCP_NOPUSH in Solaris 10

[Eric Wong <normalperson@yhbt.net>]

Edho Arief <edho@myconan.net> wrote:
> The definition of kgio_autopush_read and kgio_autopush_write (in
> read_write.c) never happened in Solaris 10: it's not linux and there's
> no TCP_NOPUSH anywhere in its system header. It caused error when
> running unicorn (and of course the test):

I don't care for non-Free platforms, but maybe some of the other BSDs
got broken, too, so I pushed out this fix to "master" on
git://bogomips.org/kgio.git

>From 85ae255f73b9b81ae3d17e6420dbb95a29dbe8b7 Mon Sep 17 00:00:00 2001
From: Eric Wong <normalperson@yhbt.net>
Date: Mon, 19 Mar 2012 05:53:03 +0000
Subject: [PATCH] fix for non-Linux, non-TCP_NOPUSH platforms

We don't need to care for TCP_NOPUSH in read_write.c, it's
entirely in autopush.c and no-op on platforms without
TCP_CORK/TCP_NOPUSH.  TCP_CORK/TCP_NOPUSH are non-POSIX, so
it's entirely possible some Free systems will lack them.

Reported-by: Edho Arief <edho@myconan.net>
---
 ext/kgio/read_write.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/ext/kgio/read_write.c b/ext/kgio/read_write.c
index 9c2440e..51d2d16 100644
--- a/ext/kgio/read_write.c
+++ b/ext/kgio/read_write.c
@@ -20,11 +20,8 @@ static inline void kgio_autopush_write(VALUE io) { }
 
 #else
 static const int peek_flags = MSG_PEEK;
-#  include <netinet/tcp.h>
-#  if defined(TCP_NOPUSH)
 static inline void kgio_autopush_read(VALUE io) { kgio_autopush_recv(io); }
 static inline void kgio_autopush_write(VALUE io) { kgio_autopush_send(io); }
-#  endif
 #endif
 
 NORETURN(static void raise_empty_bt(VALUE, const char *));