From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS47066 71.19.144.0/20 X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00, MSGID_FROM_MTA_HEADER shortcircuit=no autolearn=unavailable version=3.3.2 Path: news.gmane.org!not-for-mail From: Eric Wong Newsgroups: gmane.comp.lang.ruby.kgio.general Subject: Re: Concurrency issue in TestKgioUnixConnect? Date: Mon, 2 Sep 2013 21:24:29 +0000 Message-ID: <20130902212429.GA18310@dcvr.yhbt.net> References: <20130901140301.GI1272@loar> <20130901195835.GB30612@dcvr.yhbt.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1378157084 5449 80.91.229.3 (2 Sep 2013 21:24:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Sep 2013 21:24:44 +0000 (UTC) To: kgio@librelist.org Original-X-From: kgio@librelist.org Mon Sep 02 23:24:47 2013 Return-path: Envelope-to: gclrkg-kgio@m.gmane.org List-Archive: List-Help: List-Id: List-Post: List-Subscribe: List-Unsubscribe: Precedence: list Original-Sender: kgio@librelist.org Xref: news.gmane.org gmane.comp.lang.ruby.kgio.general:200 Archived-At: Received: from zedshaw2.xen.prgmr.com ([71.19.156.177]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VGbc6-0008B2-E6 for gclrkg-kgio@m.gmane.org; Mon, 02 Sep 2013 23:24:46 +0200 Received: from zedshaw2.xen.prgmr.com (unknown [IPv6:::1]) by zedshaw2.xen.prgmr.com (Postfix) with ESMTP id 7DD0E7508F for ; Mon, 2 Sep 2013 21:33:37 +0000 (UTC) Hleb Valoshka <375gnu@gmail.com> wrote: > On 9/1/13, Eric Wong wrote: > >> http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-kgio.git;a=blob;f=debian/patches/0002-Change-prefix-of-temporary-sockets-to-prevent-races.patch > > Btw, do you want me to take that patch into the upstream repo? > > As you wish, your tests are also affected by this issue, cause they > run in parallel too. I just signed-off and pushed the following out: Hleb Valoshka (2): Change prefix of temporary sockets to prevent races Don't dump 20M in case of failure I've never been hit by the issue even though I've always known it's a potential issue on very busy systems. It looks like Tempfile embeds the PID in the temporary name, so maybe the buildds are recycling PIDs very quickly? I haven't looked closely at your fakeroot workaround. > > It could be improved, too, to use a tmpdir for each test invocation. > > That would allow multiple instances of the kgio test to run safely at > > once (e.g. for different versions of ruby/rubinius). > > Hmm, interesting idea, currently in Debian tests with different > versions of ruby are run one-by-one, but who knows how such process > may be implemented in other OSes. I used to test some software in parallel under Ruby 1.8/Rubinius/1.9.1/1.9.2/1.9.3; but eventually stopped caring about 1.8, 1.9.{1,2} and Rubinius itself was taking too long to build.