Re: [PATCH] Don't use deprecated api

[Eric Wong <normalperson@yhbt.net>]

Hleb Valoshka <375gnu@gmail.com> wrote:
> The patch is almost done (it was tested with mri1.8, 1.9.3 and 2.0),
> but before I finish it, I should ask about correctness of the
> following patch. Is this replacement is correct?

Not exactly, but it actually works...

The FD arg (0, stdin) means Ruby will wake up the polling thread if
that FD is closed, however:

1) poll may not be watching FD=0
2) things tend to break if you trie to close the standard FDs,
   so Ruby (MRI at least) doesn't actually close them

I might be inclined to accept this if there's a comment about the fd=0
being a dummy arg as well as the reasoning of using this function vs
rb_thread_call_without_gvl or rb_thread_blocking_region because the
former is detectable-but-unlinkable in 1.9.3, while the later is
deprecated in 2.x

>  retry:
>  	hash2pollfds(a);
> -	nr = (int)rb_thread_blocking_region(nogvl_poll, a, RUBY_UBF_IO, NULL);
> +	nr = (int)rb_thread_io_blocking_region(nogvl_poll, a, 0);
>  	if (nr < 0) {
>  		if (interrupted()) {
>  			if (retryable(a)) {