From ecf3623e988b3545f638d05fe824786e1045c306 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 28 Oct 2019 20:19:18 +0000 Subject: test: fix warnings with RUBYOPT=-w --- test/lib_read_write.rb | 2 ++ test/lib_server_accept.rb | 11 +++++++---- test/test_tryopen.rb | 5 +++-- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/test/lib_read_write.rb b/test/lib_read_write.rb index 5f70964..a32919f 100644 --- a/test/lib_read_write.rb +++ b/test/lib_read_write.rb @@ -166,6 +166,7 @@ module LibReadWriteTest rescue EOFError break rescue => e + warn "#{e.message} (#{e.class})" end while true dig.hexdigest end @@ -203,6 +204,7 @@ module LibReadWriteTest rescue EOFError break rescue => e + warn "#{e.message} (#{e.class})" end while true dig.hexdigest end diff --git a/test/lib_server_accept.rb b/test/lib_server_accept.rb index db0d120..fcf9c87 100644 --- a/test/lib_server_accept.rb +++ b/test/lib_server_accept.rb @@ -20,6 +20,7 @@ module LibServerAccept b = @srv.kgio_tryaccept assert_kind_of Kgio::Socket, b assert_equal @host, b.kgio_addr + a.close end def test_tryaccept_flags @@ -28,6 +29,7 @@ module LibServerAccept b = @srv.kgio_tryaccept nil, 0 assert_kind_of Kgio::Socket, b assert_equal 0, b.fcntl(Fcntl::F_GETFD) + a.close end def test_blocking_accept_flags @@ -36,6 +38,7 @@ module LibServerAccept b = @srv.kgio_accept nil, 0 assert_kind_of Kgio::Socket, b assert_equal 0, b.fcntl(Fcntl::F_GETFD) + a.close end def test_tryaccept_fail @@ -44,7 +47,7 @@ module LibServerAccept def test_blocking_accept t0 = Time.now - pid = fork { sleep 1; a = client_connect; sleep } + pid = fork { sleep 1; a = client_connect; sleep; a.close } b = @srv.kgio_accept elapsed = Time.now - t0 assert_kind_of Kgio::Socket, b @@ -57,7 +60,7 @@ module LibServerAccept def test_blocking_accept_with_nonblock_socket @srv.nonblock = true t0 = Time.now - pid = fork { sleep 1; a = client_connect; sleep } + pid = fork { sleep 1; a = client_connect; sleep; a.close } b = @srv.kgio_accept elapsed = Time.now - t0 assert_kind_of Kgio::Socket, b @@ -67,7 +70,7 @@ module LibServerAccept assert elapsed >= 1, "elapsed: #{elapsed}" t0 = Time.now - pid = fork { sleep 6; a = client_connect; sleep } + pid = fork { sleep 6; a = client_connect; sleep; a.close } b = @srv.kgio_accept elapsed = Time.now - t0 assert_kind_of Kgio::Socket, b @@ -77,7 +80,7 @@ module LibServerAccept assert elapsed >= 6, "elapsed: #{elapsed}" t0 = Time.now - pid = fork { sleep 1; a = client_connect; sleep } + pid = fork { sleep 1; a = client_connect; sleep; a.close } b = @srv.kgio_accept elapsed = Time.now - t0 assert_kind_of Kgio::Socket, b diff --git a/test/test_tryopen.rb b/test/test_tryopen.rb index abcbd37..2bbbc51 100644 --- a/test/test_tryopen.rb +++ b/test/test_tryopen.rb @@ -59,8 +59,9 @@ class TestTryopen < Test::Unit::TestCase tmp.close! file = Kgio::File.tryopen(path, IO::RDWR|IO::CREAT, 0000) assert_equal 0100000, File.stat(path).mode - ensure - File.unlink path + file.close + ensure + File.unlink path end require "benchmark" -- cgit v1.2.3-24-ge0c7