From a270f2d2f80d28a9c3f46b652ca222e80e130968 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 3 Feb 2017 22:56:06 +0000 Subject: socket_common: expand IO#write garbage workaround to 2.0 and 2.1 On reading more carefully, it seems this change is from r34847 which landed in Ruby 2.0. So we still need to support Ruby 2.0 and 2.1 users. --- lib/mogilefs/socket_common.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/mogilefs/socket_common.rb b/lib/mogilefs/socket_common.rb index 886c738..212f5da 100644 --- a/lib/mogilefs/socket_common.rb +++ b/lib/mogilefs/socket_common.rb @@ -58,9 +58,10 @@ module MogileFS::SocketCommon # Workaround for https://bugs.ruby-lang.org/issues/13085 # (excessive garbage from IO#write) - # This looks like it will be fixed in Ruby 2.5 final. + # This regression was introduced in Ruby 2.0 (r34847) + # and looks like it will be fixed in Ruby 2.5 final. if defined?(RUBY_ENGINE) && RUBY_ENGINE == 'ruby' && - RUBY_VERSION.to_f >= 2.2 && RUBY_VERSION.to_f <= 2.4 + RUBY_VERSION.to_f >= 2.0 && RUBY_VERSION.to_f <= 2.4 def write(buf) # Blocking TCP writes would error out long before one day, # and MogileFS won't allow file creations which take over a day. -- cgit v1.2.3-24-ge0c7