From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS16276 91.121.0.0/16 X-Spam-Status: No, score=-1.0 required=3.0 tests=AWL,BAYES_00,KHOP_DYNAMIC, RCVD_IN_XBL shortcircuit=no autolearn=no version=3.3.2 X-Original-To: rainbows-public@bogomips.org Received: from 80x24.org (ns359843.ip-91-121-159.eu [91.121.159.196]) by dcvr.yhbt.net (Postfix) with ESMTP id 386CD1FD52 for ; Sat, 21 Nov 2015 08:52:38 +0000 (UTC) From: Eric Wong To: rainbows-public@bogomips.org Subject: [PATCH 1/5] tiny bytecode reductions for cold paths Date: Sat, 21 Nov 2015 08:52:28 +0000 Message-Id: <20151121085232.23086-2-e@80x24.org> In-Reply-To: <20151121085232.23086-1-e@80x24.org> References: <20151121085232.23086-1-e@80x24.org> List-Id: Less code in cold paths can improve speed for hot paths. Single-byte strings for String#split is optimized in mainline Ruby, so it's not actually a performance loss for sendfile_range in response.rb Regexps are at least 400 bytes each, so prefer non-Regexps if possible, especially for cold sites where performance does not matter. --- lib/rainbows/http_server.rb | 4 ++-- lib/rainbows/response.rb | 4 ++-- lib/rainbows/stream_response_epoll.rb | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/rainbows/http_server.rb b/lib/rainbows/http_server.rb index 429539c..33bb96c 100644 --- a/lib/rainbows/http_server.rb +++ b/lib/rainbows/http_server.rb @@ -82,10 +82,10 @@ def svc end def use=(mod) - @use = mod.to_s.split(/::/)[-1].to_sym + @use = mod.to_s.split('::')[-1].to_sym new_defaults = { 'rainbows.model' => @use, - 'rack.multithread' => !!(mod.to_s =~ /Thread/), + 'rack.multithread' => mod.to_s.include?('Thread'), 'rainbows.autochunk' => [:Coolio,:Rev,:Epoll,:XEpoll, :EventMachine,:NeverBlock].include?(@use), } diff --git a/lib/rainbows/response.rb b/lib/rainbows/response.rb index 0b5e542..9bbea81 100644 --- a/lib/rainbows/response.rb +++ b/lib/rainbows/response.rb @@ -40,7 +40,7 @@ def write_headers(status, headers, alive, body) else if /\n/ =~ value # avoiding blank, key-only cookies with /\n+/ - buf << value.split(/\n+/).map! { |v| "#{key}: #{v}\r\n" }.join + value.split(/\n+/).each { |v| buf << "#{key}: #{v}\r\n" } else buf << "#{key}: #{value}\r\n" end @@ -151,7 +151,7 @@ def sendfile_range(status, headers) 200 == status && /\Abytes=(\d+-\d*|\d*-\d+)\z/ =~ @hp.env['HTTP_RANGE'] or return - a, b = $1.split(/-/) + a, b = $1.split('-'.freeze) # HeaderHash is quite expensive, and Rack::File currently # uses a regular Ruby Hash with properly-cased headers the diff --git a/lib/rainbows/stream_response_epoll.rb b/lib/rainbows/stream_response_epoll.rb index 7c2f4f6..48ef298 100644 --- a/lib/rainbows/stream_response_epoll.rb +++ b/lib/rainbows/stream_response_epoll.rb @@ -39,7 +39,7 @@ def http_response_write(socket, status, headers, body) else if /\n/ =~ value # avoiding blank, key-only cookies with /\n+/ - buf << value.split(/\n+/).map! { |v| "#{key}: #{v}\r\n" }.join + value.split(/\n+/).each { |v| buf << "#{key}: #{v}\r\n" } else buf << "#{key}: #{value}\r\n" end -- EW