From: Graham Hughes <graham-nkzjiHSqi6rZJqsBc5GL+g@public.gmane.org>
To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
Subject: Fwd: Patch to fix use in Rainbows! with arguments
Date: Mon, 7 Feb 2011 18:02:36 -0800 [thread overview]
Message-ID: <AANLkTikGAcTXW32tuMvwVWDo4U+pBxUq5+7m-7xA3LtB@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinySo=C2S84M6V5kbibOVfhkkLM00Bkfoa+GLns-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hello. I found an annoying error in Rainbows after 0.97 that I traced
down to inaccurate scoping in one of the modules; I think this never
came up in your tests because you don't test use in config.rb with
arguments: we were running the following:
Rainbows! do
use :NeverBlock, :pool_size => 50
worker_connections 100
end
which broke.
Enclosed is a patch which fixes this issue.
Graham
From 366ab17b95c0c618f9f49c6ff20ff3218cc26344 Mon Sep 17 00:00:00 2001
From: Graham Hughes <graham@rightscale.com>
Date: Mon, 7 Feb 2011 16:49:31 -0800
Subject: [PATCH] Actually use the Rainbows::O constant for use
---
lib/rainbows/http_server.rb | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/rainbows/http_server.rb b/lib/rainbows/http_server.rb
index 71ed192..ab214c3 100644
--- a/lib/rainbows/http_server.rb
+++ b/lib/rainbows/http_server.rb
@@ -63,8 +63,8 @@ class Rainbows::HttpServer < Unicorn::HttpServer
raise ArgumentError, "concurrency model #{model.inspect} not supported"
args.each do |opt|
case opt
- when Hash; O.update(opt)
- when Symbol; O[opt] = true
+ when Hash; Rainbows::O.update(opt)
+ when Symbol; Rainbows::O[opt] = true
else; raise ArgumentError, "can't handle option: #{opt.inspect}"
end
end
--
1.7.4
_______________________________________________
Rainbows! mailing list - rainbows-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying
next parent reply other threads:[~2011-02-08 2:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTinySo=C2S84M6V5kbibOVfhkkLM00Bkfoa+GLns@mail.gmail.com>
[not found] ` <AANLkTinySo=C2S84M6V5kbibOVfhkkLM00Bkfoa+GLns-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-08 2:02 ` Graham Hughes [this message]
[not found] ` <AANLkTikGAcTXW32tuMvwVWDo4U+pBxUq5+7m-7xA3LtB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-08 3:37 ` Fwd: Patch to fix use in Rainbows! with arguments Eric Wong
[not found] ` <20110208033745.GA15989-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2011-02-08 7:03 ` Graham Hughes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/rainbows/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikGAcTXW32tuMvwVWDo4U+pBxUq5+7m-7xA3LtB@mail.gmail.com \
--to=graham-nkzjihsqi6rzjqsbc5gl+g@public.gmane.org \
--cc=rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/rainbows.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).