From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS33070 50.56.128.0/17 X-Spam-Status: No, score=0.0 required=3.0 tests=AWL,MSGID_FROM_MTA_HEADER, TVD_RCVD_IP shortcircuit=no autolearn=unavailable version=3.3.2 Path: news.gmane.org!not-for-mail From: "Lin Jen-Shin (godfat)" Newsgroups: gmane.comp.lang.ruby.rainbows.general Subject: [PATCH] close_connection_after_writing only if not deferred, as in cool.io Date: Wed, 19 Dec 2012 04:36:17 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1355863020 5501 80.91.229.3 (18 Dec 2012 20:37:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 18 Dec 2012 20:37:00 +0000 (UTC) To: "Rainbows! list" Original-X-From: rainbows-talk-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Tue Dec 18 21:37:15 2012 Return-path: Envelope-to: gclrrg-rainbows-talk@m.gmane.org X-Original-To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Delivered-To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=godfat.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=lqKfAjZWeFvyjJQobZw5mpbuLQj2WQDdLaxr+7CK3ZM=; b=xgoUCdxBHWdF2HhBbNBjBsaTkiuhHKyGfWIusuBJJrE1B71fU8qw8x7fY70oqJB4Y7 9R176+HdkMgCZwIQq62dvcRtqblGFNbda/kIyjzp926Rig6nmvtbd6QFWkR8RuCOPUQ0 iy6mYBbmeA5t6gfR87TGBaxWSn20z0KtZu6QU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:x-gm-message-state; bh=lqKfAjZWeFvyjJQobZw5mpbuLQj2WQDdLaxr+7CK3ZM=; b=Vk1DsXxzHoBHS/jN82yDowEV+mtiMDcGJja6Q9Gn9kucm3+DBm3jxnh+BQKPyECJyb J7/2i7xCROBqT7OsOmVCDDHEq46AQiMi9q+u69fRRKzCsRi3ZH5H1Uw6JjcS6xysXPzk K8xC+UAYB1UCZMnaM/QZGQxS5nIhCKnSBj+RxIpj4z95dfo3l3NQUTEz8DlEiRf3PLIu D1PBS/leXYuRaH1rcVD+6B5AeI0kc8dkng/kNOpGYGgUFjRv2LXTToh4IERXNTrlTZZV tYrL+Y1tUu4VmSGijls1HZjoMvA22vCJ8e1T01Lcf/5d/yPfSwwcAWHRBjoUx19+ynSZ r9Ng== In-Reply-To: X-Gm-Message-State: ALoCoQkCkrII3Hf1683vsL62LyKHmSB32WrRP34occJBl1KMeNQUuNcWysYD4qXPOJnicaKamr5t X-BeenThere: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: rainbows-talk-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Errors-To: rainbows-talk-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Xref: news.gmane.org gmane.comp.lang.ruby.rainbows.general:422 Archived-At: Received: from 50-56-192-79.static.cloud-ips.com ([50.56.192.79] helo=rubyforge.org) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tl3uX-0008Pe-TK for gclrrg-rainbows-talk@m.gmane.org; Tue, 18 Dec 2012 21:37:10 +0100 Received: from localhost.localdomain (localhost [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 991DF2E07B; Tue, 18 Dec 2012 20:36:56 +0000 (UTC) Received: from mail-lb0-f173.google.com (mail-lb0-f173.google.com [209.85.217.173]) by rubyforge.org (Postfix) with ESMTP id 5D69C2E076 for ; Tue, 18 Dec 2012 20:36:50 +0000 (UTC) Received: by mail-lb0-f173.google.com with SMTP id c1so1110817lbg.32 for ; Tue, 18 Dec 2012 12:36:48 -0800 (PST) Received: by 10.112.49.102 with SMTP id t6mr1326923lbn.60.1355863007977; Tue, 18 Dec 2012 12:36:47 -0800 (PST) Received: by 10.114.24.130 with HTTP; Tue, 18 Dec 2012 12:36:17 -0800 (PST) I don't have 100% confidence about this, but running test suite "t/t0002-graceful.sh" during my development for EventMachineThreadPool would need this to properly pass the tests. I think this would be needed while using `throw :async' as well? The patch is also available on Github: https://github.com/godfat/rainbows/pull/1 >>From bd5c38005f44bbe003bd416f7f871f15b0010c85 Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin Date: Wed, 19 Dec 2012 04:03:55 +0800 Subject: [PATCH] close_connection_after_writing only if not deferred, as in cool.io --- lib/rainbows/event_machine/client.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rainbows/event_machine/client.rb b/lib/rainbows/event_machine/client.rb index fc0dfe3..ebb6f17 100644 --- a/lib/rainbows/event_machine/client.rb +++ b/lib/rainbows/event_machine/client.rb @@ -28,7 +28,7 @@ class Rainbows::EventMachine::Client < EM::Connection def quit super - close_connection_after_writing + close_connection_after_writing if nil == @deferred end def app_call input -- 1.8.0.2 _______________________________________________ Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org http://rubyforge.org/mailman/listinfo/rainbows-talk Do not quote signatures (like this one) or top post when replying