Rainbows! Rack HTTP server user/dev discussion
 help / color / Atom feed
* [PATCH] Remove deprecated Rainbows::HttpResponse
@ 2011-08-05 21:24 Pratik Naik
       [not found] ` <1312579461-17223-1-git-send-email-pratiknaik-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Pratik Naik @ 2011-08-05 21:24 UTC (permalink / raw)
  To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw; +Cc: Pratik Naik

---
 lib/rainbows.rb               |    1 -
 lib/rainbows/http_response.rb |   26 --------------------------
 2 files changed, 0 insertions(+), 27 deletions(-)
 delete mode 100644 lib/rainbows/http_response.rb

diff --git a/lib/rainbows.rb b/lib/rainbows.rb
index 3bf7717..bfa1ba0 100644
--- a/lib/rainbows.rb
+++ b/lib/rainbows.rb
@@ -121,7 +121,6 @@ module Rainbows
 
   autoload :Fiber, 'rainbows/fiber' # core class
   autoload :StreamFile, 'rainbows/stream_file'
-  autoload :HttpResponse, 'rainbows/http_response' # deprecated
   autoload :ThreadTimeout, 'rainbows/thread_timeout'
   autoload :WorkerYield, 'rainbows/worker_yield'
   autoload :SyncClose, 'rainbows/sync_close'
diff --git a/lib/rainbows/http_response.rb b/lib/rainbows/http_response.rb
deleted file mode 100644
index 564d2d0..0000000
--- a/lib/rainbows/http_response.rb
+++ /dev/null
@@ -1,26 +0,0 @@
-# -*- encoding: binary -*-
-# :enddoc:
-# deprecated, use Rainbows::Response instead
-# Cramp 0.11 relies on this, and is only activated by Cramp
-if defined?(Cramp) && defined?(Rainbows::EventMachine::Client)
-  class Rainbows::HttpResponse
-    # dummy method for Cramp to alias_method_chain
-    def self.write(client, response, out)
-    end
-  end
-
-  module Rainbows::EventMachine::CrampSocket
-    def em_write_response(response, alive = false)
-      if websocket?
-        write web_socket_upgrade_data
-        web_socket_handshake!
-        response[1] = nil # disable response headers
-      end
-      super
-    end
-  end
-
-  class Rainbows::EventMachine::Client
-    include Rainbows::EventMachine::CrampSocket
-  end
-end
-- 
1.7.3.4

_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Remove deprecated Rainbows::HttpResponse
       [not found] ` <1312579461-17223-1-git-send-email-pratiknaik-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2011-08-05 22:07   ` Eric Wong
       [not found]     ` <20110805220714.GA6456-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Wong @ 2011-08-05 22:07 UTC (permalink / raw)
  To: Rainbows! list; +Cc: Pratik Naik

Thanks!  Is the next version of Cramp ready-to-release soonish?

The test suite currently relies on 0.13 and it fails with this
patch applied, but cramp.git now relies on my latest changes to
rainbows.git...

So does the chicken or egg come first? :)

I will hold off on applying this patch until the next Cramp
is out, http_response.rb shouldn't break anything just by being
in the Rainbows! tree another release.

I suppose I can release the current rainbows.git as Rainbows! 4.2.0
today (a good version number :D) just for Cramp.

-- 
Eric Wong
_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Remove deprecated Rainbows::HttpResponse
       [not found]     ` <20110805220714.GA6456-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
@ 2011-08-05 22:27       ` Pratik
       [not found]         ` <CADtcy21gt2YbEjET5GcqFHCxtRvsjxheFaz+E+XWJoBOOBKZFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Pratik @ 2011-08-05 22:27 UTC (permalink / raw)
  To: Rainbows! list

On 5 August 2011 23:07, Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> wrote:
> I suppose I can release the current rainbows.git as Rainbows! 4.2.0
> today (a good version number :D) just for Cramp.

Perfect. I just released cramp 0.14. Waiting for Rainbows! 4.2.0 :)

>
> --
> Eric Wong
>



-- 
Programmer @ 37signals | http://twitter.com/lifo | http://m.onkey.org
_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Remove deprecated Rainbows::HttpResponse
       [not found]         ` <CADtcy21gt2YbEjET5GcqFHCxtRvsjxheFaz+E+XWJoBOOBKZFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2011-08-05 23:51           ` Eric Wong
       [not found]             ` <20110805235144.GA27634-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Wong @ 2011-08-05 23:51 UTC (permalink / raw)
  To: Rainbows! list

Pratik <pratiknaik-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 5 August 2011 23:07, Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> wrote:
> > I suppose I can release the current rainbows.git as Rainbows! 4.2.0
> > today (a good version number :D) just for Cramp.
> 
> Perfect. I just released cramp 0.14. Waiting for Rainbows! 4.2.0 :)

Just released 4.2.0 and have HttpResponse removal queued up for 4.3.0.

I suppose Cramp has a smallish userbase and nobody's going to be
stuck on 0.13 and unable to upgrade, right?

-- 
Eric Wong
_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Remove deprecated Rainbows::HttpResponse
       [not found]             ` <20110805235144.GA27634-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
@ 2011-08-06 15:20               ` Pratik
  0 siblings, 0 replies; 5+ messages in thread
From: Pratik @ 2011-08-06 15:20 UTC (permalink / raw)
  To: Rainbows! list

On 6 August 2011 00:51, Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> wrote:
> Just released 4.2.0 and have HttpResponse removal queued up for 4.3.0.
>
> I suppose Cramp has a smallish userbase and nobody's going to be
> stuck on 0.13 and unable to upgrade, right?

Thanks! Yup I'm pretty sure no one will be stuck on 0.13.

-- 
Programmer @ 37signals | http://twitter.com/lifo | http://m.onkey.org
_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-05 21:24 [PATCH] Remove deprecated Rainbows::HttpResponse Pratik Naik
     [not found] ` <1312579461-17223-1-git-send-email-pratiknaik-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-08-05 22:07   ` Eric Wong
     [not found]     ` <20110805220714.GA6456-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2011-08-05 22:27       ` Pratik
     [not found]         ` <CADtcy21gt2YbEjET5GcqFHCxtRvsjxheFaz+E+XWJoBOOBKZFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-05 23:51           ` Eric Wong
     [not found]             ` <20110805235144.GA27634-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2011-08-06 15:20               ` Pratik

Rainbows! Rack HTTP server user/dev discussion

Archives are clonable:
	git clone --mirror http://bogomips.org/rainbows-public
	git clone --mirror http://ou63pmih66umazou.onion/rainbows-public

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.rainbows
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.rainbows

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git