From: Eric Wong <e@80x24.org>
To: ruby-posix-mq@bogomips.org
Subject: [PATCH] freeze internal objects
Date: Mon, 20 Mar 2017 19:13:21 +0000 [thread overview]
Message-ID: <20170320191321.10809-1-e@80x24.org> (raw)
We do not want ObjectSpace walkers to be able to mess with
our internals.
---
ext/posix_mq/posix_mq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ext/posix_mq/posix_mq.c b/ext/posix_mq/posix_mq.c
index 83e9e58..4ba7d7c 100644
--- a/ext/posix_mq/posix_mq.c
+++ b/ext/posix_mq/posix_mq.c
@@ -523,7 +523,7 @@ static VALUE init(int argc, VALUE *argv, VALUE self)
rb_sys_fail("mq_open");
}
- mq->name = rb_str_dup(name);
+ mq->name = rb_str_new_frozen(name);
if (x.oflags & O_NONBLOCK)
mq->attr.mq_flags = O_NONBLOCK;
@@ -887,6 +887,7 @@ static VALUE name(VALUE self)
rb_raise(rb_eArgError, "can not get name of an adopted socket");
}
+ /* XXX compatibility: in retrospect, we could return a frozen string */
return rb_str_dup(mq->name);
}
@@ -907,6 +908,7 @@ static int lookup_sig(VALUE sig)
VALUE mSignal = rb_const_get(rb_cObject, rb_intern("Signal"));
list = rb_funcall(mSignal, rb_intern("list"), 0, 0);
+ rb_obj_freeze(list);
rb_global_variable(&list);
}
--
EW
reply other threads:[~2017-03-20 19:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/ruby_posix_mq/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320191321.10809-1-e@80x24.org \
--to=e@80x24.org \
--cc=ruby-posix-mq@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/ruby_posix_mq.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).