From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 73BE71FADF; Tue, 30 Jan 2018 23:58:35 +0000 (UTC) From: Eric Wong To: ruby-posix-mq@bogomips.org Cc: Eric Wong Subject: [PATCH] drop extra args to rb_funcall Date: Tue, 30 Jan 2018 23:58:33 +0000 Message-Id: <20180130235833.14952-1-e@80x24.org> List-Id: This was harmless in Ruby 2.4, but Ruby 2.5 with newer versions of clang are not happy about it. Eventually this may be fixed in Ruby 2.5.1: https://bugs.ruby-lang.org/issues/14425 --- ext/posix_mq/posix_mq.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ext/posix_mq/posix_mq.c b/ext/posix_mq/posix_mq.c index 4ba7d7c..6a5439b 100644 --- a/ext/posix_mq/posix_mq.c +++ b/ext/posix_mq/posix_mq.c @@ -907,7 +907,7 @@ static int lookup_sig(VALUE sig) if (!list) { VALUE mSignal = rb_const_get(rb_cObject, rb_intern("Signal")); - list = rb_funcall(mSignal, rb_intern("list"), 0, 0); + list = rb_funcall(mSignal, rb_intern("list"), 0); rb_obj_freeze(list); rb_global_variable(&list); } @@ -961,7 +961,7 @@ static void lower_stack_size(pthread_attr_t *attr) /* :nodoc: */ static VALUE setnotify_exec(VALUE self, VALUE io, VALUE thr) { - int fd = NUM2INT(rb_funcall(io, id_fileno, 0, 0)); + int fd = NUM2INT(rb_funcall(io, id_fileno, 0)); struct posix_mq *mq = get(self, 1); struct sigevent not; pthread_attr_t attr; @@ -979,7 +979,7 @@ static VALUE setnotify_exec(VALUE self, VALUE io, VALUE thr) not.sigev_value.sival_int = fd; if (!NIL_P(mq->thread)) - rb_funcall(mq->thread, id_kill, 0, 0); + rb_funcall(mq->thread, id_kill, 0); mq->thread = thr; my_mq_notify(mq->des, ¬); @@ -993,7 +993,7 @@ static VALUE notify_cleanup(VALUE self) struct posix_mq *mq = get(self, 1); if (!NIL_P(mq->thread)) { - rb_funcall(mq->thread, id_kill, 0, 0); + rb_funcall(mq->thread, id_kill, 0); mq->thread = Qnil; } return Qnil; -- EW