From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, T_RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: normalperson@yhbt.net Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9C07E1F6F9; Tue, 24 Sep 2013 21:05:07 +0000 (UTC) Date: Tue, 24 Sep 2013 21:05:07 +0000 From: Eric Wong To: sleepy.penguin@librelist.org Subject: Re: [sleepy.penguin] [PATCH] Support for broken system without clock_gettime. Message-ID: <20130924210507.GA10409@dcvr.yhbt.net> References: <1380012947-91938-1-git-send-email-godfat@godfat.org> <20130924180901.GA8085@dcvr.yhbt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) List-Id: "Lin Jen-Shin (godfat)" wrote: > On Wed, Sep 25, 2013 at 2:09 AM, Eric Wong wrote: > > Lin Jen-Shin wrote: > > Pushed with the following commit addendum: > [...] > > Thank you! Thank you for the patch! > > I'm not sure why you switched to spaces for indentation. I just changed > > it back to match the original clogger code. > > (my preferred C indentation style is based on Linux kernel conventions) > > Doh! I am sorry for that, it's a mistake. Usually I would just follow the > original coding style. I guess I might be too tired recently so was not > careful enough this time :/ No worries. Btw, do you have time to run/write more tests for the kqueue code? I think the RARRAY_PTR usage should be replaced with newer RARRAY_* macros or even just rb_ary_entry in some places for 2.1.0 and rbx. (ref: comments in https://bugs.ruby-lang.org/issues/8399)