From: Eric Wong <e@80x24.org>
To: unicorn-public@bogomips.org
Subject: [PATCH] stream_input: favor String#clear over String#replace
Date: Sat, 22 Aug 2015 04:42:49 +0000 [thread overview]
Message-ID: <1440218569-25476-1-git-send-email-e@80x24.org> (raw)
We no longer need Ruby 1.8 compatibility, so use String#clear
to reduce argument passing and code size.
---
lib/unicorn/stream_input.rb | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/unicorn/stream_input.rb b/lib/unicorn/stream_input.rb
index 9278f47..de5aeea 100644
--- a/lib/unicorn/stream_input.rb
+++ b/lib/unicorn/stream_input.rb
@@ -53,7 +53,7 @@ class Unicorn::StreamInput
rv << @rbuf
to_read -= @rbuf.size
end
- @rbuf.replace('')
+ @rbuf.clear
end
rv = nil if rv.empty? && length != 0
else
@@ -130,8 +130,8 @@ private
filter_body(@rbuf, @buf)
dst << @rbuf
end
- ensure
- @rbuf.replace('')
+ ensure
+ @rbuf.clear
end
def eof!
--
EW
reply other threads:[~2015-08-22 4:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440218569-25476-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=unicorn-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).