From: Jeremy Evans <code@jeremyevans.net>
To: Eric Wong <e@80x24.org>
Cc: unicorn-public@bogomips.org
Subject: Re: [PATCH] Add worker_exec configuration option V2
Date: Fri, 10 Mar 2017 21:26:52 -0800 [thread overview]
Message-ID: <20170311052652.GB80208@jeremyevans.local> (raw)
In-Reply-To: <20170310211907.GA5022@untitled>
On 03/10 09:19, Eric Wong wrote:
> Jeremy Evans <code@jeremyevans.net> wrote:
> > Here's V2 of the patch, which I think should address all of the issues
> > you pointed out.
>
> Thanks. Pushed to git://80x24.org/unicorn worker_exec I can add
> tests, later, or you can. I also had some FreeBSD test fixes
> (which might apply to OpenBSD) on a VM somewhere which I'll Cc:
> you on: there was also just SO_KEEPALIVE fix I posted:
>
> https://bogomips.org/unicorn-public/20170310203431.28067-1-e@80x24.org/raw
The C test code also returns 8 on OpenBSD, FWIW. I'm happy to test any
test fixes on OpenBSD, just let me know.
>
> > worker_nr = -1
> > until (worker_nr += 1) == @worker_processes
> > @workers.value?(worker_nr) and next
> > worker = Unicorn::Worker.new(worker_nr)
> > before_fork.call(self, worker)
> > - if pid = fork
> > - @workers[pid] = worker
> > - worker.atfork_parent
> > +
> > + pid = if @worker_exec
> > + worker_spawn(worker)
> > else
> > - after_fork_internal
> > - worker_loop(worker)
> > - exit
> > + fork do
> > + after_fork_internal
> > + worker_loop(worker)
> > + exit
> > + end
>
> I prefer to avoid the block with fork. The block deepens the
> stack for the running app, so it can affect GC efficiency.
>
> Can be fixed in a separate patch...
That makes sense. If you would like me to send a separate patch to fix
it, I can do that.
Thanks,
Jeremy
next prev parent reply other threads:[~2017-03-11 5:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 18:44 [PATCH] Add worker_exec configuration option Jeremy Evans
2017-03-08 20:02 ` Eric Wong
2017-03-09 4:52 ` Jeremy Evans
2017-03-09 13:57 ` Eric Wong
2017-03-09 19:41 ` [PATCH] Add worker_exec configuration option V2 Jeremy Evans
2017-03-10 21:19 ` Eric Wong
2017-03-11 5:26 ` Jeremy Evans [this message]
2017-03-11 7:18 ` Eric Wong
2017-03-13 15:32 ` Jeremy Evans
2017-03-13 19:18 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170311052652.GB80208@jeremyevans.local \
--to=code@jeremyevans.net \
--cc=e@80x24.org \
--cc=unicorn-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).