From: Jeremy Evans <code@jeremyevans.net>
To: Eric Wong <e@80x24.org>
Cc: unicorn-public@bogomips.org
Subject: Re: [PATCH] Add worker_exec configuration option V2
Date: Mon, 13 Mar 2017 08:32:58 -0700 [thread overview]
Message-ID: <20170313153258.GE80208@jeremyevans.local> (raw)
In-Reply-To: <20170311071849.GA25506@whir>
On 03/11 07:18, Eric Wong wrote:
> Jeremy Evans <code@jeremyevans.net> wrote:
> > On 03/10 09:19, Eric Wong wrote:
> > > Jeremy Evans <code@jeremyevans.net> wrote:
> > > > - if pid = fork
> > > > - @workers[pid] = worker
> > > > - worker.atfork_parent
> > > > +
> > > > + pid = if @worker_exec
> > > > + worker_spawn(worker)
> > > > else
> > > > - after_fork_internal
> > > > - worker_loop(worker)
> > > > - exit
> > > > + fork do
> > > > + after_fork_internal
> > > > + worker_loop(worker)
> > > > + exit
> > > > + end
> > >
> > > I prefer to avoid the block with fork. The block deepens the
> > > stack for the running app, so it can affect GC efficiency.
> > >
> > > Can be fixed in a separate patch...
> >
> > That makes sense. If you would like me to send a separate patch to fix
> > it, I can do that.
>
> Yes, please.
>
> Not sure if we should automate the stack depth test...
> I resisted it in the past since it might be too fragile
> w.r.t changes to Ruby (even using "unicorn" via the
> RubyGems-generated wrapper deepens it by 2).
Here's a patch to fix the stack depth issue:
From aa4914846a0870e5b01530a47d6dbfe09aeb39ce Mon Sep 17 00:00:00 2001
From: Jeremy Evans <code@jeremyevans.net>
Date: Mon, 13 Mar 2017 08:28:54 -0700
Subject: [PATCH] Don't pass a block for fork when forking workers
This reduces the stack depth, making GC more efficient.
---
lib/unicorn/http_server.rb | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/lib/unicorn/http_server.rb b/lib/unicorn/http_server.rb
index a5bd2c4..023df10 100644
--- a/lib/unicorn/http_server.rb
+++ b/lib/unicorn/http_server.rb
@@ -541,14 +541,12 @@ def spawn_missing_workers
worker = Unicorn::Worker.new(worker_nr)
before_fork.call(self, worker)
- pid = if @worker_exec
- worker_spawn(worker)
- else
- fork do
- after_fork_internal
- worker_loop(worker)
- exit
- end
+ pid = @worker_exec ? worker_spawn(worker) : fork
+
+ unless pid
+ after_fork_internal
+ worker_loop(worker)
+ exit
end
@workers[pid] = worker
--
2.11.0
next prev parent reply other threads:[~2017-03-13 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 18:44 [PATCH] Add worker_exec configuration option Jeremy Evans
2017-03-08 20:02 ` Eric Wong
2017-03-09 4:52 ` Jeremy Evans
2017-03-09 13:57 ` Eric Wong
2017-03-09 19:41 ` [PATCH] Add worker_exec configuration option V2 Jeremy Evans
2017-03-10 21:19 ` Eric Wong
2017-03-11 5:26 ` Jeremy Evans
2017-03-11 7:18 ` Eric Wong
2017-03-13 15:32 ` Jeremy Evans [this message]
2017-03-13 19:18 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313153258.GE80208@jeremyevans.local \
--to=code@jeremyevans.net \
--cc=e@80x24.org \
--cc=unicorn-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).