From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bofh@yhbt.net>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 801FB1F55F
	for <unicorn-public@yhbt.net>; Wed,  4 Oct 2023 03:06:59 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yhbt.net;
	s=selector1; t=1696388819;
	bh=WnlHjiM5kyHi7cC+eKO3HJGj4SbYDFKZw7rqNrMlvao=;
	h=Date:From:To:Subject:References:In-Reply-To:From;
	b=Ssb5QRUbAZvzSdMJfyDYt2tedNWnK7ZCEZNr1UXvuvOViTcGIWo/0kFPUdBtZXzEd
	 EOVwqnlFY/AoTh03h2VSK54BjjJZ8oqIp8yF6drakBQa42Ai1xiaj0s9y9StGTFUwY
	 JNfKjL7LCHKKDu2ces/CzC/ShTPovPSaOG0cKDlo=
Date: Wed, 4 Oct 2023 03:06:59 +0000
From: Eric Wong <bofh@yhbt.net>
To: unicorn-public@yhbt.net
Subject: Re: [RFC 0-3/3] depend on Ruby 2.5+, eliminate kgio
Message-ID: <20231004030659.M341393@dcvr>
References: <20230905094420.M199613@dcvr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230905094420.M199613@dcvr>
List-Id: <unicorn-public.yhbt.net>

Eric Wong <bofh@yhbt.net> wrote:
> Patch 2/3 could use an extra set of eyes since it's fairly big,
> but passes all tests.

Any comments?  Anybody still on Ruby <= 2.4?

> +      filter_body(once = '', @socket.readpartial(@@io_chunk_size, @buf))
> +++ b/lib/unicorn/http_request.rb
> @@ -61,7 +61,7 @@ def self.check_client_connection=(bool)
>    # returns an environment hash suitable for Rack if successful
>    # This does minimal exception trapping and it is up to the caller
>    # to handle any socket errors (e.g. user aborted upload).
> -  def read(socket)
> +  def read_headers(socket, ai)

O_O  OMG we haz AI now!  Think of the marketing potential!


Disclaimer: I have never and will never use any form of
intelligence (artificial or otherwise) in writing unicorn.