Re: trying to update unicorn to 5.1, build failure: VERSION= must be specified

Re: trying to update unicorn to 5.1, build failure: VERSION= must be specified

[Eric Wong]

Hleb Valoshka <375gnu@gmail.com> wrote:
> On 9/19/16, Pirate Praveen <praveen@onenetbeyond.org> wrote:
> > Its pushed to alioth. Can someone check?
> >
> > Error below:
> >
> > $ clean
> > dh clean --buildsystem=ruby --with ruby,systemd
> >    dh_testdir -O--buildsystem=ruby
> >    dh_auto_clean -O--buildsystem=ruby
> > 	dh_ruby --clean
> >    dh_ruby --clean
> > VERSION= must be specified
> > dh_auto_clean: dh_ruby --clean returned exit code 1
> > debian/rules:6: recipe for target 'clean' failed
> > make: *** [clean] Error 1
> 
> This is not the only problem, then you should have olddoc gem, I
> remember that I tried to fix these error, but I don't see my changes,
> maybe I did this on my home pc, I'll look there.

(oops, missed this earlier)

I understand olddoc may not be worth the effort to package in
Debian.  (I already tried to reduce dependencies in olddoc
compared to wrongdoc, but a package is a package...)

Anyways, I suggest you guys grab the generated gemspec from the
Rubygem or tar.gz.  You already seem to be doing that with NEWS
and the manpages to avoid a build-dep on pandoc(*).

Maybe the gemspec in git could have olddoc become optional, too,
while still remaining DRY.  The email address for the public
mailing list is already specified in multiple places, so maybe
over-DRY-ing isn't worth it...

Anyways, feel free to email me + Cc: unicorn-public@bogomips.org
w.r.t. any packaging/integration issues for any Free Software
systems (not just Debian)


(*) - I'll be switching over to perlpod at some point and
      pod2man is standard in Debian.  I hate having to spend
      ~30MB of bandwidth fees to get ghc + pandoc to build
      manpages.

Re: trying to update unicorn to 5.1, build failure: VERSION= must be specified

[Pirate Praveen]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

On Friday 28 October 2016 05:53 AM, Eric Wong wrote:
> I understand olddoc may not be worth the effort to package in
> Debian.  (I already tried to reduce dependencies in olddoc
> compared to wrongdoc, but a package is a package...)
> 
> Anyways, I suggest you guys grab the generated gemspec from the
> Rubygem or tar.gz.  You already seem to be doing that with NEWS
> and the manpages to avoid a build-dep on pandoc(*).

We are already using the rubygems.org .gem file and it has olddoc.

> Maybe the gemspec in git could have olddoc become optional, too,
> while still remaining DRY.  The email address for the public
> mailing list is already specified in multiple places, so maybe
> over-DRY-ing isn't worth it...

If you can make it optional that would be great. For now I've just
patched out the gemspec to not use olddoc. The patch and fix in rules is
ugly.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[PATCH] gemspec: remove olddoc from build dependency

[Eric Wong]

Pirate Praveen <praveen@onenetbeyond.org> wrote:
> If you can make it optional that would be great. For now I've just
> patched out the gemspec to not use olddoc. The patch and fix in rules is
> ugly.

Pushed the following to "master" of git://bogomips.org/unicorn

-----8<----
Subject: [PATCH] gemspec: remove olddoc from build dependency

It's a little less DRY, and there'll be no NEWS file generated,
but it's one less thing to install, so perhaps that's worth it.
The website at https://bogomips.org/unicorn/ will continue
to use olddoc, of course,
---
 HACKING         |  1 -
 unicorn.gemspec | 22 ++++++++++------------
 2 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/HACKING b/HACKING
index d55f1c7..be1bb85 100644
--- a/HACKING
+++ b/HACKING
@@ -104,7 +104,6 @@ don't email the git mailing list or maintainer with Unicorn patches :)
 
 In order to build the gem, you must install the following components:
 
- * olddoc (RubyGem)
  * pandoc
 
 You can build the Unicorn gem with the following command:
diff --git a/unicorn.gemspec b/unicorn.gemspec
index cf65aef..6dc0086 100644
--- a/unicorn.gemspec
+++ b/unicorn.gemspec
@@ -1,9 +1,6 @@
 # -*- encoding: binary -*-
-ENV["VERSION"] or abort "VERSION= must be specified"
-manifest = File.readlines('.manifest').map! { |x| x.chomp! }
-require 'olddoc'
-extend Olddoc::Gemspec
-name, summary, title = readme_metadata
+manifest = File.exist?('.manifest') ?
+  IO.readlines('.manifest').map!(&:chomp!) : `git ls-files`.split("\n")
 
 # don't bother with tests that fork, not worth our time to get working
 # with `gem check -t` ... (of course we care for them when testing with
@@ -14,16 +11,18 @@
 
 Gem::Specification.new do |s|
   s.name = %q{unicorn}
-  s.version = ENV["VERSION"].dup
-  s.authors = ["#{name} hackers"]
-  s.summary = summary
-  s.description = readme_description
+  s.version = (ENV['VERSION'] || '5.2.0').dup
+  s.authors = ['unicorn hackers']
+  s.summary = 'Rack HTTP server for fast clients and Unix'
+  s.description = File.read('README').split("\n\n")[1]
   s.email = %q{unicorn-public@bogomips.org}
   s.executables = %w(unicorn unicorn_rails)
   s.extensions = %w(ext/unicorn_http/extconf.rb)
-  s.extra_rdoc_files = extra_rdoc_files(manifest)
+  s.extra_rdoc_files = IO.readlines('.document').map!(&:chomp!).keep_if do |f|
+    File.exist?(f)
+  end
   s.files = manifest
-  s.homepage = Olddoc.config['rdoc_url']
+  s.homepage = 'https://bogomips.org/unicorn/'
   s.test_files = test_files
 
   # technically we need ">= 1.9.3", too, but avoid the array here since
@@ -40,7 +39,6 @@
   s.add_dependency(%q<raindrops>, '~> 0.7')
 
   s.add_development_dependency('test-unit', '~> 3.0')
-  s.add_development_dependency('olddoc', '~> 1.2')
 
   # Note: To avoid ambiguity, we intentionally avoid the SPDX-compatible
   # 'Ruby' here since Ruby 1.9.3 switched to BSD-2-Clause, but we
-- 
EW