From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A6875202D7 for ; Wed, 8 Mar 2017 12:06:57 +0000 (UTC) Received: by mail-wm0-x234.google.com with SMTP id 196so29709714wmm.1 for ; Wed, 08 Mar 2017 04:06:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopify.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BqCNkoW56fgh4uHhF32VySW7GGshu1iFksTx+GMoCJs=; b=a78e87mQa1xRrIdOz//h4dshyF9f2jaSUsKrNBZudXPzlbOQvllQcOcEsBHJv5meu/ jS9FgxEgK+Whr47LJLuJmwGyY8E/owPj4KdZkvqnu3L1iIN+vFnvYxpsdeZtr89XuufN 4+bpqF9nKqTFNl3fsl5hiDkSKNRbgY63hZrnA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BqCNkoW56fgh4uHhF32VySW7GGshu1iFksTx+GMoCJs=; b=QdCXGPrKDLFHIokDh5xe+eRX4LQJe6O23xCLrZwFjcQw02uHdyiS/7Vqwi4Qb9OkTn 74lL6biWs1lmgPoY3jnAz9wiIZJfcTIaAwI2Ad4VJJYe7yKvMzgU2aGbd7JLVv4ML4oF z6BU28USXtcALCE0fsOJ6Pxv87BgDFhBidiMZUHm6v5eNfThFV141Du65CP78x/gbBBk mR5DzuQF5RJZXEI1mZ2hInV40Zu24GxAOBgeGfCQJq3OKLfL1aIyAPQaCANFowHGe5Hv QNDbf6GRg6/AadV7h/UftxBiVKg22EmefJMf/EMFtapZ/C9VhXiT9xP4u2PhD+zs8Z8b tV5g== X-Gm-Message-State: AMke39n7b+u6PM07N6mMR/O3+ysauC8P9BeUgWjd4YqOdecGc0pPNfGcoA0R7pvGiWHOJtMiu277hRuobF2Z/STt X-Received: by 10.28.8.147 with SMTP id 141mr16106412wmi.43.1488974816129; Wed, 08 Mar 2017 04:06:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.229.14 with HTTP; Wed, 8 Mar 2017 04:06:55 -0800 (PST) In-Reply-To: <20170308002608.GA382@whir> References: <20170225231243.GA6224@dcvr.yhbt.net> <20170228211254.GA3868@whir> <20170301031828.GA19430@dcvr> <20170307225045.GA19463@whir> <20170308002608.GA382@whir> From: Simon Eskildsen Date: Wed, 8 Mar 2017 07:06:55 -0500 Message-ID: Subject: Re: [PATCH] check_client_connection: use tcp state on linux To: Eric Wong Cc: unicorn-public@bogomips.org Content-Type: text/plain; charset=UTF-8 List-Id: Patch-set looks great Eric, thanks! I'm hoping to test this in production later this week or next, but we're a year behind on Unicorn (ugh), so will need to carefully roll that out. On Tue, Mar 7, 2017 at 7:26 PM, Eric Wong wrote: > Eric Wong wrote: >> Simon Eskildsen wrote: >> > @@ -28,6 +29,7 @@ class Unicorn::HttpParser >> > # Drop these frozen strings when Ruby 2.2 becomes more prevalent, >> > # 2.2+ optimizes hash assignments when used with literal string keys >> > HTTP_RESPONSE_START = [ 'HTTP', '/1.1 '] >> > + EMPTY_ARRAY = [].freeze >> >> (minor) this was made before commit e06b699683738f22 >> ("http_request: freeze constant strings passed IO#write") >> but I've trivially fixed it up, locally. > > And I actually screwed it up, pushed out ccc-tcp-v2 branch > with that fix squashed in :x > > Writing tests, now...