From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 695971F4B4 for ; Wed, 9 Dec 2020 14:58:51 +0000 (UTC) Received: by mail-qk1-x730.google.com with SMTP id z11so1432099qkj.7 for ; Wed, 09 Dec 2020 06:58:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blakewilliams-me.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc:reply-to :content-transfer-encoding:message-id:references:to; bh=EfJs2R8RDUbGyOWsYoX8X9cMOsZcC4Tq1GetRQjg+cE=; b=UnZuax512isBnS++O14IgxwYFw5M+RRpnLIF0DSlgeKw5Nk8N700rYJPK9IzesOQpL CflrxdvFJTF6vr476YGzjB/P/5vpmTSQtVQJz0Flx/tS5J0haZV9YyAtITJxgy1fRVHz JvynhsYRt7mTN0GSj8KjNfh82jWy8zpXDEjtu1cf1eQyUR8kxkkJWHaT6IZJgAV6vAUL K7oWZ531CUTbtL3/NvVl00fb0pVKwQS0LGAhGAgD67kmyrvF958HzVOOmvTOw62+cFkB y7QS3wITyX3bS005kVFiYiXRwwMKDQrECthdxhe+o7J/Ib0AmxK14FNwPH8IVgnf7S5P HK9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :reply-to:content-transfer-encoding:message-id:references:to; bh=EfJs2R8RDUbGyOWsYoX8X9cMOsZcC4Tq1GetRQjg+cE=; b=g0Drwfk3PKuT9kCfCAxwtFthffa2gBz4F4IPi+4RF+Dt7S3GV0HGlijZCbrcfB0wun rYi+wOVRuPzm8EQsLowRG1eimuUt5ZNnAlfecIcdyvwhZQOYxL0DNhIYP2p/q4Ca/0Z0 Ov0KTvOYTPAT/lE+NvQgCOh1JLPmQ11kZdvUYXu7fzLoX6dzwa1WRC9JM5Mb0Gzo0ETO B9P/JNnQdKQrJc2RuvJxnfvYPoXmYjI5n1Nd+D7NDTAJNVTAK3YQEIseZYinDpGA5deG eiF2+6++Lac3U/WUpAdKEnYxdTeFPV2TfLfbuW7GNxSkqob+4X7PAyA8THu3saRtjOeB eSJw== X-Gm-Message-State: AOAM531gF9iz4pgLFW4LaCVxbjiY71+fp7nguryfvJT75hHLZSmg+ztF lYBHVT7DUr+80hr/WisbQ/LZLg== X-Google-Smtp-Source: ABdhPJyTik/s48yt3QqObA7rWdUIRrc/I9glZxOp9ht4vr9ctnK2rfX18B9ktafBDuCszdrGq+9ewA== X-Received: by 2002:a37:9c07:: with SMTP id f7mr3375581qke.191.1607525930249; Wed, 09 Dec 2020 06:58:50 -0800 (PST) Received: from [192.168.1.246] (inet-64-112-182-228.bos.netblazr.com. [64.112.182.228]) by smtp.gmail.com with ESMTPSA id h64sm1169182qkd.42.2020.12.09.06.58.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2020 06:58:49 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: [PATCH] Add rack.after_reply functionality From: Blake Williams In-Reply-To: <20201209094344.GA25593@dcvr> Date: Wed, 9 Dec 2020 09:58:48 -0500 Cc: unicorn-public@yhbt.net Reply-To: 20201209094344.GA25593@dcvr Content-Transfer-Encoding: quoted-printable Message-Id: References: <9873E53C-04D3-4759-9678-CA17DBAEF7B7@blakewilliams.me> <20201208224631.GA13148@dcvr> <20201209094344.GA25593@dcvr> To: Eric Wong X-Mailer: Apple Mail (2.3608.120.23.2.4) List-Id: > OK. Keep in mind this can be server-dependent since unicorn > can't support persistent connections while (most?) other servers > do (and they may disable TCP_CORK or Nagle, etc). I see, I=E2=80=99ll look into this as well. >>> Citation(s) needed. Also, are there any proposal(s) to get this >>> into the Rack specification? >>=20 >> Not that I=E2=80=99m aware of. But I agree that it and early_hints = could both be >> good additions to the spec. >=20 > By "Citation(s) needed", can you list some other (preferably > well-known) Rack servers which also implement this feature? >=20 > We wouldn't want current unicorn users thinking we're adopting > random new things which nobody else supports :> >=20 > Thanks. Totally understood. I looked at Puma, Thin, and Webrick and only Puma supports this functionality without a third-party gem. There is at least = one third party gem adding this functionality to web servers that don=E2=80=99= t support it, but it doesn=E2=80=99t look like it=E2=80=99s being maintained any = longer. I briefly dove into the Puma source and it looks like rack.after_reply = has been supported since 2011. It=E2=80=99s also still in use by Puma for = their common=20 logger middleware patch.=