unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Ken Dreyer <ktdreyer@ktdreyer.com>
Cc: unicorn-public@bogomips.org, mongrel-unicorn@rubyforge.org
Subject: Re: [PATCH] tests: switch to minitest
Date: Tue, 13 May 2014 01:13:53 +0000	[thread overview]
Message-ID: <20140513011353.GA9713@dcvr.yhbt.net> (raw)
In-Reply-To: <CAD3FbMVKBc4xypOXZgZbrzXpoKt92JgAH3ZpRMDbz2jRTZ8Q9A@mail.gmail.com>

Ken Dreyer <ktdreyer@ktdreyer.com> wrote:
> I am seeing one failure with the final assert in
> TestSocketHelper#test_bind_listen_unix_rebind, but I don't think
> that's a result of this, right?

That's a new failure for me.  Sorry about the lack of info in my
original response :x

I'm failing on minitest 5.3.3, 4.7.5 seems fine, in fact.

Below the output of "make -j8 test-unit V=1" on my machine (Ruby 2.1),
same failures on trunk, too (with minitest 5.3.3 installed)

: 
:   1) Failure:
: TestSocketHelper#test_bind_listen_unix_rebind [test/unit/test_socket_helper.rb:123]:
: Failed assertion, no message given.

<snip>

:   1) Failure:
: TestStreamInput#test_big_body_multi [test/unit/test_stream_input.rb:89]:
: Failed assertion, no message given.
: 
: 
:   2) Failure:
: TestStreamInput#test_gets_long [test/unit/test_stream_input.rb:110]:
: Failed assertion, no message given.
: 
make: *** [test/unit/test_stream_input.rb] Error 1

<snip>

:   1) Failure:
: TestTeeInput#test_gets_short [test/unit/test_tee_input.rb:69]:
: Failed assertion, no message given.
: 
: 
:   2) Failure:
: TestTeeInput#test_big_body_multi [test/unit/test_tee_input.rb:150]:
: Failed assertion, no message given.
: 
: 
:   3) Failure:
: TestTeeInput#test_chunked_ping_pong [test/unit/test_tee_input.rb:216]:
: Failed assertion, no message given.
: 
: 
:   4) Failure:
: TestTeeInput#test_chunked [test/unit/test_tee_input.rb:185]:
: Failed assertion, no message given.
: 
: 
:   5) Failure:
: TestTeeInput#test_chunked_with_trailer [test/unit/test_tee_input.rb:244]:
: Failed assertion, no message given.
: 
: 
:   6) Failure:
: TestTeeInput#test_gets_long [test/unit/test_tee_input.rb:50]:
: Failed assertion, no message given.
: 
: 
:   7) Failure:
: TestTeeInput#test_read_in_full_if_content_length [test/unit/test_tee_input.rb:123]:
: Failed assertion, no message given.
: 
: 12 runs, 57449 assertions, 7 failures, 0 errors, 0 skips
make: *** [test/unit/test_tee_input.rb] Error 1

  reply	other threads:[~2014-05-13  1:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-26  3:20 [PATCH] tests: switch to minitest Ken Dreyer
2014-04-26  6:07 ` Eric Wong
2014-05-13  0:46   ` Ken Dreyer
2014-05-13  1:13     ` Eric Wong [this message]
2014-05-29 19:17       ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140513011353.GA9713@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=ktdreyer@ktdreyer.com \
    --cc=mongrel-unicorn@rubyforge.org \
    --cc=unicorn-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).