unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Dan Moore <dan@vaporwa.re>
Cc: unicorn-public@bogomips.org
Subject: Re: SIGWINCH ignored...
Date: Wed, 20 May 2015 23:11:04 +0000	[thread overview]
Message-ID: <20150520231104.GA22455@dcvr.yhbt.net> (raw)
In-Reply-To: <6067929621305539263@unknownmsgid>

Dan Moore <dan@vaporwa.re> wrote:
> Thank you, that's perfect. +1 for unicorn 5 patch.

Thanks for the confirmation, pushed as the following commit:

commit a6077391bb62d0b13016084b0eea36b987afe8f0
Author: Eric Wong <e@80x24.org>
Date:   Wed May 20 22:15:48 2015 +0000

    process SIGWINCH unless stdin is a TTY
    
    Some process managers such as foreman and daemontools rely on
    unicorn not daemonizing, but we still want to be able to process
    SIGWINCH in that case.
    
    stdout and stderr may be redirected to a pipe (for cronolog or
    similar process), so those are less likely to be attached to a TTY
    than stdin.  This also allows users to process SIGWINCH when running
    inside a regular terminal if they redirect stdin to /dev/null.
    
    Reported-by: Dan Moore <dan@vaporwa.re>
    References: <etPan.555b4293.5b47a5b7.e617@danbookpro>
    	<20150519232858.GA23515@dcvr.yhbt.net>

      reply	other threads:[~2015-05-20 23:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 14:02 SIGWINCH ignored Dan Moore
2015-05-19 23:28 ` Eric Wong
     [not found] ` <861658785.98319.1432078146036.JavaMail.mobile-sync@ioii68>
2015-05-20  1:02   ` Dan Moore
2015-05-20 23:11     ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520231104.GA22455@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=dan@vaporwa.re \
    --cc=unicorn-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).