clogger RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: clogger-public@bogomips.org
Subject: [PATCH] ext: get rid of noisy and unnecessary cast
Date: Tue, 13 Jan 2015 02:16:38 +0000	[thread overview]
Message-ID: <1421115399-9327-2-git-send-email-e@80x24.org> (raw)

---
 ext/clogger_ext/clogger.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/ext/clogger_ext/clogger.c b/ext/clogger_ext/clogger.c
index 6531d87..3db9235 100644
--- a/ext/clogger_ext/clogger.c
+++ b/ext/clogger_ext/clogger.c
@@ -238,19 +238,18 @@ static struct clogger *clogger_get(VALUE self)
 }
 
 /* only for writing to regular files, not stupid crap like NFS  */
-static void write_full(int fd, const void *buf, size_t count)
+static void write_full(int fd, const char *buf, size_t count)
 {
 	ssize_t r;
-	unsigned long ubuf = (unsigned long)buf;
 
 	while (count > 0) {
-		r = write(fd, (void *)ubuf, count);
+		r = write(fd, buf, count);
 
 		if ((size_t)r == count) { /* overwhelmingly likely */
 			return;
 		} else if (r > 0) {
 			count -= r;
-			ubuf += r;
+			buf += r;
 		} else {
 			if (errno == EINTR || errno == EAGAIN)
 				continue; /* poor souls on NFS and like: */
-- 
2.2.1.203.g624e5c2


                 reply	other threads:[~2015-01-13  2:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/clogger/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421115399-9327-2-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=clogger-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/clogger.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).