From: Eric Wong <e@80x24.org>
To: clogger-public@bogomips.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] clogger.c: comment to explain the lack of GC guard
Date: Tue, 17 Jan 2017 19:22:41 +0000 [thread overview]
Message-ID: <20170117192241.22814-1-e@80x24.org> (raw)
If I (the person who wrote this) spent a minute figuring out why
it wasn't needed, somebody else might, too. Save someone else
a minute.
---
ext/clogger_ext/clogger.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ext/clogger_ext/clogger.c b/ext/clogger_ext/clogger.c
index f29cf26..83ce76a 100644
--- a/ext/clogger_ext/clogger.c
+++ b/ext/clogger_ext/clogger.c
@@ -682,6 +682,7 @@ static VALUE cwrite(struct clogger *c)
if (c->fd >= 0) {
write_full(c->fd, RSTRING_PTR(dst), RSTRING_LEN(dst));
+ /* no need for RB_GC_GUARD(dst) here, marked as c->log_buf */
} else {
VALUE logger = c->logger;
--
EW
reply other threads:[~2017-01-17 19:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/clogger/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117192241.22814-1-e@80x24.org \
--to=e@80x24.org \
--cc=clogger-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/clogger.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).