From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E11CA20756; Tue, 17 Jan 2017 19:22:42 +0000 (UTC) From: Eric Wong To: clogger-public@bogomips.org Cc: Eric Wong Subject: [PATCH] clogger.c: comment to explain the lack of GC guard Date: Tue, 17 Jan 2017 19:22:41 +0000 Message-Id: <20170117192241.22814-1-e@80x24.org> List-Id: If I (the person who wrote this) spent a minute figuring out why it wasn't needed, somebody else might, too. Save someone else a minute. --- ext/clogger_ext/clogger.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ext/clogger_ext/clogger.c b/ext/clogger_ext/clogger.c index f29cf26..83ce76a 100644 --- a/ext/clogger_ext/clogger.c +++ b/ext/clogger_ext/clogger.c @@ -682,6 +682,7 @@ static VALUE cwrite(struct clogger *c) if (c->fd >= 0) { write_full(c->fd, RSTRING_PTR(dst), RSTRING_LEN(dst)); + /* no need for RB_GC_GUARD(dst) here, marked as c->log_buf */ } else { VALUE logger = c->logger; -- EW