From: Eric Wong <e@80x24.org>
To: clogger-public@bogomips.org
Subject: [PATCH] ext: reduce frozen string marking overhead
Date: Wed, 15 Feb 2017 22:32:36 +0000 [thread overview]
Message-ID: <20170215223236.25484-1-e@80x24.org> (raw)
Using rb_global_variable excessively can be expensive since it
uses a singly-linked list to track addresses. Since these
strings are all frozen and constant, put them into an array
instead and only mark the array as a global to improve locality.
Ruby 1.9+ has rb_gc_register_mark_object but it is
not part of the documented, public API, so we're not
using it, yet.
---
ext/clogger_ext/clogger.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/ext/clogger_ext/clogger.c b/ext/clogger_ext/clogger.c
index 83ce76a..481dd61 100644
--- a/ext/clogger_ext/clogger.c
+++ b/ext/clogger_ext/clogger.c
@@ -29,6 +29,7 @@
* under.
*/
static clockid_t hopefully_CLOCK_MONOTONIC;
+static VALUE mark_ary;
static void check_clock(void)
{
@@ -949,7 +950,7 @@ static VALUE clogger_init_copy(VALUE clone, VALUE orig)
#define CONST_GLOBAL_STR2(var, val) do { \
g_##var = rb_obj_freeze(rb_str_new(val, sizeof(val) - 1)); \
- rb_global_variable(&g_##var); \
+ rb_ary_push(mark_ary, g_##var); \
} while (0)
#define CONST_GLOBAL_STR(val) CONST_GLOBAL_STR2(val, #val)
@@ -1015,6 +1016,9 @@ void Init_clogger_ext(void)
{
VALUE tmp;
+ mark_ary = rb_ary_new();
+ rb_global_variable(&mark_ary);
+
check_clock();
write_id = rb_intern("write");
@@ -1060,4 +1064,6 @@ void Init_clogger_ext(void)
tmp = rb_const_get(rb_cObject, rb_intern("Rack"));
tmp = rb_const_get(tmp, rb_intern("Utils"));
cHeaderHash = rb_const_get(tmp, rb_intern("HeaderHash"));
+
+ rb_obj_freeze(mark_ary);
}
--
EW
reply other threads:[~2017-02-15 22:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/clogger/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215223236.25484-1-e@80x24.org \
--to=e@80x24.org \
--cc=clogger-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/clogger.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).