clogger RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
						download: 
* [PATCH] clogger.c: comment to explain the lack of GC guard
@ 2017-01-17 19:22 Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2017-01-17 19:22 UTC (permalink / raw)
  To: clogger-public; +Cc: Eric Wong

If I (the person who wrote this) spent a minute figuring out why
it wasn't needed, somebody else might, too.  Save someone else
a minute.
---
 ext/clogger_ext/clogger.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ext/clogger_ext/clogger.c b/ext/clogger_ext/clogger.c
index f29cf26..83ce76a 100644
--- a/ext/clogger_ext/clogger.c
+++ b/ext/clogger_ext/clogger.c
@@ -682,6 +682,7 @@ static VALUE cwrite(struct clogger *c)
 
 	if (c->fd >= 0) {
 		write_full(c->fd, RSTRING_PTR(dst), RSTRING_LEN(dst));
+		/* no need for RB_GC_GUARD(dst) here, marked as c->log_buf */
 	} else {
 		VALUE logger = c->logger;
 
-- 
EW


^ permalink raw reply	[relevance 7%]

* [ANN] clogger 2.2.0 - configurable request logging for Rack
@ 2017-05-23  8:46 Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2017-05-23  8:46 UTC (permalink / raw)
  To: clogger-public, ruby-talk; +Cc: Pat Allan

Clogger is Rack middleware for logging HTTP requests.  The log format
is customizable so you can specify exactly which fields to log.

* https://bogomips.org/clogger/
* mail archives: https://bogomips.org/clogger-public/
* email us: clogger-public@bogomips.org (publically archived)
* git clone https://bogomips.org/clogger.git
* git clone git://bogomips.org/clogger
* https://bogomips.org/clogger/NEWS.atom.xml

Changes:

    clogger v2.2.0 - Rack 2.x compatibility fix
    
    This release fixes a Rack compatibility problem when
    Rack::BodyProxy wraps the Clogger object and calls
    "respond_to?" with two arguments.  This affects folks
    who put Clogger at lower levels of the middleware stack
    (below middlewares which use Rack::BodyProxy)
    
    A huge thanks to Pat Allan for coming up with this fix.
    
    Note, the recommended usage of clogger middleware is to have
    it at the outermost layer of the Rack middleware stack where
    it can give the most accurate $request_time measurement.
    
    There's also a couple of tiny internal improvements
    around the build and miniscule GC overhead reduction.
    
    Pat Allan (1):
          Update respond_to? calls for second argument.
    
    Eric Wong (3):
          clogger.c: comment to explain the lack of GC guard
          ext: reduce frozen string marking overhead
          build: remove build-time olddoc dependency
-- 
clogger v2.2.0

^ permalink raw reply	[relevance 4%]

Results 1-2 of 2 | reverse results
2017-01-17 19:22 [PATCH] clogger.c: comment to explain the lack of GC guard Eric Wong
2017-05-23  8:46 [ANN] clogger 2.2.0 - configurable request logging for Rack Eric Wong


clogger RubyGem user+dev discussion/patches/pulls/bugs/help

Archives are clonable:
	git clone --mirror https://bogomips.org/clogger-public
	git clone --mirror http://ou63pmih66umazou.onion/clogger-public

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.clogger
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.clogger

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox