From: Mykola Golub <trociny@FreeBSD.org>
To: Eric Wong <e@80x24.org>
Cc: cmogstored-public@bogomips.org
Subject: Re: FreeBSD: sleeper using ppoll does not sleep forever
Date: Tue, 10 Mar 2015 21:23:12 +0200 [thread overview]
Message-ID: <20150310192311.GA5161@gmail.com> (raw)
In-Reply-To: <20150309203543.GA18791@dcvr.yhbt.net>
On Mon, Mar 09, 2015 at 08:35:43PM +0000, Eric Wong wrote:
> Thanks, there's at least two problems in cmogstored here:
>
> 1) The assertion could trigger on any OS due to the lack of retry
> on EINTR.
>
> 2) ppoll is non-POSIX, and is a cancellation point in GNU libc,
> but perhaps not the FreeBSD libc based on your bug report.
> We'll switch to pselect which POSIX as a cancellation point.
>
> I suggest FreeBSD developers make ppoll a thread cancellation
> point for GNU/Linux compatibility.
>
> So two patches coming in reply to this email...
Cool! Works here. Thanks.
--
Mykola Golub
prev parent reply other threads:[~2015-03-10 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 15:18 FreeBSD: sleeper using ppoll does not sleep forever Mykola Golub
2015-03-09 20:35 ` Eric Wong
2015-03-09 20:49 ` [PATCH 1/2] Fix assertion failure during startup Eric Wong
2015-03-09 20:49 ` [PATCH 2/2] avoid relying on ppoll as a cancellation point Eric Wong
2015-03-10 19:23 ` Mykola Golub [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/cmogstored/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310192311.GA5161@gmail.com \
--to=trociny@freebsd.org \
--cc=cmogstored-public@bogomips.org \
--cc=e@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/cmogstored.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).