From: Eric Wong <e@80x24.org>
To: cmogstored-public@bogomips.org
Subject: [PATCH] test/mgmt_auto_adjust.rb: improve diagnostic messages
Date: Sat, 27 Apr 2019 21:26:32 +0000 [thread overview]
Message-ID: <20190427212632.25926-1-e@80x24.org> (raw)
Chasing down a regression in Linux 5.0:
https://lkml.kernel.org/r/20190427093319.sgicqik2oqkez3wk@dcvr
---
test/mgmt_auto_adjust.rb | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/test/mgmt_auto_adjust.rb b/test/mgmt_auto_adjust.rb
index 8ec725f..311747d 100644
--- a/test/mgmt_auto_adjust.rb
+++ b/test/mgmt_auto_adjust.rb
@@ -80,6 +80,7 @@ def test_aio_threads_auto_adjust
RUBY_PLATFORM !~ /kfreebsd-gnu/
def test_aio_threads_auto_adjust_warn
+ at = Time.now
@client.write "server aio_threads = 1\r\n"
assert_equal "\r\n", @client.gets
stop = Time.now + 60
@@ -87,7 +88,8 @@ def test_aio_threads_auto_adjust_warn
while (! File.read(@err.path).include?(expect) && Time.now < stop)
sleep 0.1
end
- assert(File.read(@err.path).include?(expect), File.read(@err.path))
+ msg = File.read(@err.path)
+ assert(msg.include?(expect), "msg[#@pid]: #{msg} #{at}")
Dir.mkdir("#@tmpdir/dev333")
warning = "fewer aio_threads(1) than devices(2)"
@@ -95,6 +97,7 @@ def test_aio_threads_auto_adjust_warn
while (! File.read(@err.path).include?(warning)) && Time.now < stop
sleep 0.1
end
- assert(File.read(@err.path).include?(warning), File.read(@err.path))
+ msg = File.read(@err.path)
+ assert(msg.include?(warning), "msg[#@pid]: #{msg} #{at}")
end
end
--
EW
reply other threads:[~2019-04-27 21:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/cmogstored/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190427212632.25926-1-e@80x24.org \
--to=e@80x24.org \
--cc=cmogstored-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/cmogstored.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).