From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-3.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 99D921F4B4;
	Wed, 20 Jan 2021 21:22:29 +0000 (UTC)
Date: Wed, 20 Jan 2021 21:22:29 +0000
From: Eric Wong <e@80x24.org>
To: Xiao Yu <xyu@automattic.com>
Cc: Arkadi Colson <arkadi@smartbit.be>, cmogstored-public@yhbt.net
Subject: Re: Segfaults on http_close?
Message-ID: <20210120212229.GA25024@dcvr>
References: <CABfxMcXPr7q8o1ayRdn1x-Fukuh7-s3YG=04KX=vAzz4DYqhuQ@mail.gmail.com>
 <20210111212621.GA12555@dcvr>
 <20210117095109.GA28219@dcvr>
 <CABfxMcWGu+7X9Y-A7gTSYwsXpDRyYxGDtom3imV6-J3vT_qJPA@mail.gmail.com>
 <20210120085745.GB29704@dcvr>
 <CABfxMcVhLa5PPUAn8hHTekTnvJytSqYcawXxn4D+uefS5edBFQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CABfxMcVhLa5PPUAn8hHTekTnvJytSqYcawXxn4D+uefS5edBFQ@mail.gmail.com>
List-Id: <cmogstored-public.yhbt.net>

Xiao Yu <xyu@automattic.com> wrote:
> That's good to know, would it help if I applied the patch and then
> compiled with the older compiler to check?

Yes, that would be tremendously helpful, thanks.

> Would non-daemonized mode and capturing stderr provide more verbosity?

Yes, syslog can't capture fatal errors from glibc, unfortunately.
It might only be one line, but that could tell you what kind of free()
failure there was.

--daemonize/-d behavior was a mistake copied from Perl mogstored :<
I'm not sure if I want to add another option or env variable...
(I use systemd myself)