diff options
| author | Junio C Hamano <gitster@pobox.com> | 2016-07-11 10:44:13 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-07-11 10:44:13 -0700 |
| commit | 5220b7589b09d62e7166799baa98dcd6a1c02804 (patch) | |
| tree | a747488ef8d9538f63aea908e73912bb07ef83e2 | |
| parent | 1a88ca99db81b0a5d0f43b57df4a265055d81436 (diff) | |
| parent | 01247e0299b34b9b46d96d5850a24583e39deabe (diff) | |
| download | git-svn-5220b7589b09d62e7166799baa98dcd6a1c02804.tar.gz | |
Fix unnecessarily waste in the idiomatic use of ': ${VAR=default}'
to set the default value, without enclosing it in double quotes.
* lc/shell-default-value-noexpand:
sh-setup: enclose setting of ${VAR=default} in double-quotes
| -rw-r--r-- | git-sh-setup.sh | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/git-sh-setup.sh b/git-sh-setup.sh index c48139a494..85db5f1c63 100644 --- a/git-sh-setup.sh +++ b/git-sh-setup.sh @@ -160,8 +160,8 @@ git_pager() { else GIT_PAGER=cat fi - : ${LESS=-FRX} - : ${LV=-c} + : "${LESS=-FRX}" + : "${LV=-c}" export LESS LV eval "$GIT_PAGER" '"$@"' @@ -344,7 +344,7 @@ git_dir_init () { echo >&2 "Unable to determine absolute path of git directory" exit 1 } - : ${GIT_OBJECT_DIRECTORY="$(git rev-parse --git-path objects)"} + : "${GIT_OBJECT_DIRECTORY="$(git rev-parse --git-path objects)"}" } if test -z "$NONGIT_OK" |