From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A2EC2206A5; Fri, 28 Oct 2016 20:15:05 +0000 (UTC) From: Eric Wong To: http_spew-public@bogomips.org Cc: Eric Wong Subject: [PATCH 2/5] test_upload: use object_id to check matches Date: Fri, 28 Oct 2016 20:15:00 +0000 Message-Id: <20161028201503.10315-3-e@80x24.org> In-Reply-To: <20161028201503.10315-1-e@80x24.org> References: <20161028201503.10315-1-e@80x24.org> List-Id: We do not define <=> for comparison, so object_id is safer and more future-proof. --- test/test_upload.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/test_upload.rb b/test/test_upload.rb index 33c494a..df54765 100644 --- a/test/test_upload.rb +++ b/test/test_upload.rb @@ -117,13 +117,16 @@ class TestUpload < Test::Unit::TestCase req << HTTP_Spew::Request.new(@env, StringIO.new(str), @sockaddr) req << HTTP_Spew::Request.new(@env, StringIO.new(str), @sockaddr) req << HTTP_Spew::Request.new(@env, StringIO.new(str), @sockaddr) - before = req.dup + before = req.map(&:object_id) rv = HTTP_Spew.wait_nonblock!(3, req) while rv.nil? do rv = HTTP_Spew.wait_nonblock!(3, req) end assert_nil rv.uniq! assert rv.size > 0 - rv.each { |r| assert before.include?(r) } + rv.map!(&:object_id) + rv.each do |r| + assert before.include?(r), "rv=#{rv.inspect} before=#{before.inspect}" + end end end if HAVE_UNICORN -- EW