From: Eric Wong <e@80x24.org>
To: kcar-public@bogomips.org
Subject: [PATCH 3/5] drop rb_str_set_len compatibility replacement
Date: Fri, 3 Mar 2017 20:53:05 +0000 [thread overview]
Message-ID: <20170303205307.2275-4-e@80x24.org> (raw)
In-Reply-To: <20170303205307.2275-1-e@80x24.org>
While it is innocuous after compiling, it can be a confusing
source of errors for users with broken installations of Ruby
itself:
https://bogomips.org/unicorn-public/5ace6a20-e094-293d-93df-b557480e12d5@anyces.com/
https://bogomips.org/unicorn-public/02994a55-9c07-a3c5-f06b-a4c15551a67e@anyces.com/
rb_str_set_len has been provided since Ruby 1.8.7+, and we'll
be requiring Ruby 1.9.3+ in the future (and even Ruby 2.2 is EOL
nowadays)
---
ext/kcar/ext_help.h | 20 --------------------
ext/kcar/extconf.rb | 1 -
2 files changed, 21 deletions(-)
diff --git a/ext/kcar/ext_help.h b/ext/kcar/ext_help.h
index ec081e2..d227737 100644
--- a/ext/kcar/ext_help.h
+++ b/ext/kcar/ext_help.h
@@ -1,26 +1,6 @@
#ifndef ext_help_h
#define ext_help_h
-#ifndef RSTRING_PTR
-#define RSTRING_PTR(s) (RSTRING(s)->ptr)
-#endif /* !defined(RSTRING_PTR) */
-#ifndef RSTRING_LEN
-#define RSTRING_LEN(s) (RSTRING(s)->len)
-#endif /* !defined(RSTRING_LEN) */
-
-#ifndef HAVE_RB_STR_SET_LEN
-# ifdef RUBINIUS
-# error we should never get here with current Rubinius (1.x)
-# endif
-/* this is taken from Ruby 1.8.7, 1.8.6 may not have it */
-static void rb_18_str_set_len(VALUE str, long len)
-{
- RSTRING(str)->len = len;
- RSTRING(str)->ptr[len] = '\0';
-}
-# define rb_str_set_len(str,len) rb_18_str_set_len(str,len)
-#endif /* !defined(HAVE_RB_STR_SET_LEN) */
-
/* not all Ruby implementations support frozen objects (Rubinius does not) */
#if defined(OBJ_FROZEN)
# define assert_frozen(f) assert(OBJ_FROZEN(f) && "unfrozen object")
diff --git a/ext/kcar/extconf.rb b/ext/kcar/extconf.rb
index 4f19c4a..3585125 100644
--- a/ext/kcar/extconf.rb
+++ b/ext/kcar/extconf.rb
@@ -5,7 +5,6 @@ dir_config("kcar")
have_macro("SIZEOF_OFF_T", "ruby.h") or check_sizeof("off_t", "sys/types.h")
have_macro("SIZEOF_LONG", "ruby.h") or check_sizeof("long", "sys/types.h")
-have_func("rb_str_set_len", "ruby.h")
have_func("rb_str_modify", "ruby.h")
# -fPIC is needed for Rubinius, MRI already uses it regardless
--
EW
next prev parent reply other threads:[~2017-03-03 20:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 20:53 [PATCH 0/5] miscellaneous updates Eric Wong
2017-03-03 20:53 ` [PATCH 1/5] gemspec: use SPDX compatible terms for the license(s) Eric Wong
2017-03-03 20:53 ` [PATCH 2/5] archive/slrnpull.conf: add a note explaining the purpose Eric Wong
2017-03-03 20:53 ` Eric Wong [this message]
2017-03-03 20:53 ` [PATCH 4/5] remove rb_str_modify workaround Eric Wong
2017-03-03 20:53 ` [PATCH 5/5] TypedData C-API conversion Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/kcar/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303205307.2275-4-e@80x24.org \
--to=e@80x24.org \
--cc=kcar-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/kcar.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).