From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=unavailable autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 5F493207B9; Wed, 19 Apr 2017 00:13:49 +0000 (UTC) Date: Wed, 19 Apr 2017 00:13:49 +0000 From: Eric Wong To: yahns-public@yhbt.net, kcar-public@bogomips.org Subject: Re: yahns will use kcar as a request parser Message-ID: <20170419001349.GA3474@starla> References: <20170408003732.GA5176@starla> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170408003732.GA5176@starla> List-Id: The current parser used by yahns interprets X-Forwarded-Proto and X-Forwarded-Ssl headers to set rack.url_scheme in the rack request env. Since these are non-standard headers, I think we can safely drop support for them in yahns. Neither passenger, puma, nor thin seem to respect them when setting rack.url_scheme, either... Anyways, these headers are used by Rack::Request, and RFC 7239 ("Forwarded" header) was standardized in 2014, so maybe some people would rather use that instead, too...