From: Eric Wong <e@80x24.org>
To: kcar-public@bogomips.org
Subject: [PATCH 09/11] do not set "HTTP/0.9" for pre-1.0 requests
Date: Sat, 1 Dec 2018 13:31:23 +0000 [thread overview]
Message-ID: <20181201133125.5524-10-e@80x24.org> (raw)
In-Reply-To: <20181201133125.5524-1-e@80x24.org>
Since "HTTP/0.9" is an informal name, we'll omit it to avoid
confusing any applications which may see them.
---
ext/kcar/kcar.rl | 10 ----------
test/test_request_parser.rb | 2 --
2 files changed, 12 deletions(-)
diff --git a/ext/kcar/kcar.rl b/ext/kcar/kcar.rl
index e1445aa..c85eb3c 100644
--- a/ext/kcar/kcar.rl
+++ b/ext/kcar/kcar.rl
@@ -189,14 +189,6 @@ static void set_server_vars(struct http_parser *hp, VALUE env, VALUE host)
rb_hash_aset(env, g_SERVER_PORT, server_port);
}
-static void http_09_request(VALUE env)
-{
- VALUE v = str_new_dd_freeze("HTTP/0.9", 8);
-
- rb_hash_aset(env, g_SERVER_PROTOCOL, v);
- rb_hash_aset(env, g_HTTP_VERSION, v);
-}
-
static void finalize_header(struct http_parser *hp, VALUE hdr)
{
if (hp->has_trailer && !hp->chunked)
@@ -215,8 +207,6 @@ static void finalize_header(struct http_parser *hp, VALUE hdr)
VALUE host = request_host_val(hp);
if (host != Qfalse)
set_server_vars(hp, hdr, host);
- } else {
- http_09_request(hdr);
}
}
}
diff --git a/test/test_request_parser.rb b/test/test_request_parser.rb
index c4fefc8..895a948 100644
--- a/test/test_request_parser.rb
+++ b/test/test_request_parser.rb
@@ -743,8 +743,6 @@ class TestRequestParser < Test::Unit::TestCase
"REQUEST_PATH" => "/read-rfc1945-if-you-dont-believe-me",
"PATH_INFO" => "/read-rfc1945-if-you-dont-believe-me",
"REQUEST_URI" => "/read-rfc1945-if-you-dont-believe-me",
- "SERVER_PROTOCOL" => "HTTP/0.9",
- "HTTP_VERSION" => "HTTP/0.9",
"REQUEST_METHOD" => "GET",
"QUERY_STRING" => ""
}
next prev parent reply other threads:[~2018-12-01 13:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 13:31 [PATCH v2] request parsing bits Eric Wong
2018-12-01 13:31 ` [PATCH 01/11] introduce new str_new_dd_freeze internal function Eric Wong
2018-12-01 13:31 ` [PATCH 02/11] begin implementing request parsing Eric Wong
2018-12-01 13:31 ` [PATCH 03/11] favor bitfields instead flags + macros Eric Wong
2018-12-01 13:31 ` [PATCH 04/11] implement request parsing with tests Eric Wong
2018-12-01 13:31 ` [PATCH 05/11] pkg.mk: enable warnings by default for tests Eric Wong
2018-12-01 13:31 ` [PATCH 06/11] filter_body: rename variables to be like memcpy(3) Eric Wong
2018-12-01 13:31 ` [PATCH 07/11] flesh out filter_body for request parsing Eric Wong
2018-12-01 13:31 ` [PATCH 08/11] do not assume SERVER_PORT Eric Wong
2018-12-01 13:31 ` Eric Wong [this message]
2018-12-01 13:31 ` [PATCH 10/11] always set non-negative Content-Length for requests Eric Wong
2018-12-01 13:31 ` [PATCH 11/11] avoid String#-@ call on request parsing under Ruby 2.6 Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/kcar/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181201133125.5524-10-e@80x24.org \
--to=e@80x24.org \
--cc=kcar-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/kcar.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).