kcar RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
* [PATCH] extconf: fix rb_hash_aset deduplication test
@ 2018-12-15 22:48 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2018-12-15 22:48 UTC (permalink / raw)
  To: kcar-public; +Cc: Eric Wong

We must rely on a random string which is already outside
of the Ruby fstring table.
---
 ext/kcar/extconf.rb | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/ext/kcar/extconf.rb b/ext/kcar/extconf.rb
index ba69c3c..1608f70 100644
--- a/ext/kcar/extconf.rb
+++ b/ext/kcar/extconf.rb
@@ -24,8 +24,11 @@ end
 
 message('checking if Hash#[]= (rb_hash_aset) dedupes... ')
 h = {}
-h[%w(m k m f).join('')] = :foo
-if 'mkmf'.freeze.equal?(h.keys[0])
+x = {}
+r = rand.to_s
+h[%W(#{r}).join('')] = :foo
+x[%W(#{r}).join('')] = :foo
+if x.keys[0].equal?(h.keys[0])
   $CPPFLAGS += ' -DHASH_ASET_DEDUPE=1 '
   message("yes\n")
 else
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-12-15 22:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-15 22:48 [PATCH] extconf: fix rb_hash_aset deduplication test Eric Wong

Code repositories for project(s) associated with this public inbox

	https://yhbt.net/kcar.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).