[kgio] [PATCH] Fixed some typos in Kgio::SSLConnector documentation (by Iñaki Baz Castillo <ibc@aliax.ne t>).

[kgio] [PATCH] Fixed some typos in Kgio::SSLConnector documentation (by Iñaki Baz Castillo <ibc@aliax.ne t>).

[Iñaki Baz Castillo]

---
 ext/kgio_monkey/kgio_monkey.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ext/kgio_monkey/kgio_monkey.c b/ext/kgio_monkey/kgio_monkey.c
index 75ff5bd..56e8fad 100644
--- a/ext/kgio_monkey/kgio_monkey.c
+++ b/ext/kgio_monkey/kgio_monkey.c
@@ -907,7 +907,7 @@ static VALUE conn_trysendfile(int argc, VALUE *argv, VALUE self)
  * call-seq:
  *	Kgio::SSLConnector.new(io, ssl_ctx, hostname, session = nil)
  *
- * Initializes and SSL/TLS client socket.  Like Kgio::SSL.new, except
+ * Initializes an SSL/TLS client socket.  Like Kgio::SSL.new, except
  * +hostname+ is required for verification and +session+ may be specified
  * as an OpenSSL::SSL::Session object.
  */
@@ -997,7 +997,7 @@ void Init_kgio_monkey_ext(void)
 	 * Document-class: Kgio::SSLConnector
 	 *
 	 * Like Kgio::SSL, but for SSL/TLS clients that connect to
-	 * clients, not SSL/TLS servers.
+	 * servers, not for SSL/TLS servers.
 	 */
 	cConnector = rb_define_class_under(mKgio, "SSLConnector", cKgioSSL);
 	rb_define_alloc_func(cKgioSSL, ssl_alloc);
-- 
1.7.5.4

Re: [PATCH] Fixed some typos in Kgio::SSLConnector documentation

[Eric Wong]

Thanks, signed-off and pushed.

(btw, no need to put your name/email in the commit message
title/Subject, the From: header is parsed by "git am".

"git am" will also parse a From: line in the commit message
body in cases where an email sender wants to use a different
email address in the commit message than the email address
they're submitting the patch from.

Re: [PATCH] Fixed some typos in Kgio::SSLConnector documentation

[Iñaki Baz Castillo]

2012/4/11 Eric Wong <normalperson@yhbt.net>:
> Thanks, signed-off and pushed.
>
> (btw, no need to put your name/email in the commit message
> title/Subject, the From: header is parsed by "git am".

> "git am" will also parse a From: line in the commit message
> body in cases where an email sender wants to use a different
> email address in the commit message than the email address
> they're submitting the patch from.

Ops, honestly I didn't use "git am" but instead:

  git format-patch -1 -o /tmp/kk/
  git send-email
/tmp/kk/0001-Fixed-some-typos-in-Kgio-SSLConnector-documentation-.patch

(and some work in ssmtp.conf for sending via Gmail) :)

-- 
Iñaki Baz Castillo
<ibc@aliax.net>

Re: [PATCH] Fixed some typos in Kgio::SSLConnector documentation

[Eric Wong]

Iñaki Baz Castillo <ibc@aliax.net> wrote:
> Ops, honestly I didn't use "git am" but instead:

I mean *I* use "git am" to apply the patch on my end :)

("am" is short for "applymbox", git-am replaced the original
 git-applymbox script early in git development)

Re: [PATCH] Fixed some typos in Kgio::SSLConnector documentation

[Iñaki Baz Castillo]

2012/4/11 Eric Wong <normalperson@yhbt.net>:
> Iñaki Baz Castillo <ibc@aliax.net> wrote:
>> Ops, honestly I didn't use "git am" but instead:
>
> I mean *I* use "git am" to apply the patch on my end :)
>
> ("am" is short for "applymbox", git-am replaced the original
>  git-applymbox script early in git development)

Ahh ok ok :)

-- 
Iñaki Baz Castillo
<ibc@aliax.net>