From: Eric Wong <normalperson@yhbt.net>
To: kgio@librelist.org
Subject: Re: Concurrency issue in TestKgioUnixConnect?
Date: Sun, 1 Sep 2013 19:58:35 +0000 [thread overview]
Message-ID: <20130901195835.GB30612@dcvr.yhbt.net> (raw)
In-Reply-To: CAAB-KckfeHu1JWpfA3b-RRycr4x5b=dxAKfBpUrxXTYYLt6tRg@mail.gmail.com
Hleb Valoshka <375gnu@gmail.com> wrote:
> On 9/1/13, Jérémy Bobbio <lunar@debian.org> wrote:
>
> > Is there a concurrency issue in TestKgioUnixConnect?
> > Looking at the code, I see there's an underlying TOCTOU issue with how
> > the temporary socket path name is determined, but I'm not sure if that's
> > what we are seeing there…
> > Any opinions?
>
> I think you are right.
>
> I've just pushed trivial patch into team's repository to prevent this issue:
> http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-kgio.git;a=blob;f=debian/patches/0002-Change-prefix-of-temporary-sockets-to-prevent-races.patch
Btw, do you want me to take that patch into the upstream repo?
It could be improved, too, to use a tmpdir for each test invocation.
That would allow multiple instances of the kgio test to run safely at
once (e.g. for different versions of ruby/rubinius).
next prev parent reply other threads:[~2013-09-01 19:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 14:03 Concurrency issue in TestKgioUnixConnect? Jérémy Bobbio
2013-09-01 16:57 ` Hleb Valoshka
2013-09-01 19:58 ` Eric Wong [this message]
2013-09-02 12:57 ` Hleb Valoshka
2013-09-02 21:24 ` Eric Wong
2013-09-03 8:50 ` Hleb Valoshka
2013-09-03 20:05 ` Eric Wong
2013-09-05 20:53 ` Hleb Valoshka
2013-09-05 23:11 ` Eric Wong
2013-09-06 8:56 ` Hleb Valoshka
2013-09-05 7:58 ` Hleb Valoshka
2013-09-05 8:14 ` Eric Wong
2013-09-05 12:35 ` Hleb Valoshka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/kgio/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130901195835.GB30612@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=kgio@librelist.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/kgio.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).