From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS47066 71.19.144.0/20
X-Spam-Status: No, score=-1.9 required=3.0 tests=AWL,BAYES_00,
 MSGID_FROM_MTA_HEADER shortcircuit=no autolearn=unavailable version=3.3.2
Path: news.gmane.org!not-for-mail
From: Eric Wong <normalperson@yhbt.net>
Newsgroups: gmane.comp.lang.ruby.kgio.general
Subject: [PATCH] test/lib_read_write: fix trywritev blocking test
Date: Wed, 9 Apr 2014 21:57:53 +0000
Message-ID: <20140409215753.GA16840@dcvr.yhbt.net>
References: <20140409215753.GA16840@dcvr.yhbt.net>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Trace: ger.gmane.org 1397080700 23183 80.91.229.3 (9 Apr 2014 21:58:20 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Wed, 9 Apr 2014 21:58:20 +0000 (UTC)
To: kgio@librelist.org
Original-X-From: kgio@librelist.org Wed Apr 09 23:58:08 2014
Return-path: <kgio@librelist.org>
Envelope-to: gclrkg-kgio@m.gmane.org
In-Reply-To: <20140409215753.GA16840@dcvr.yhbt.net>
List-Archive: <http://librelist.com/archives/kgio/>
List-Help: <http://librelist.com/help.html>
List-Id: <kgio-public@bogomips.org>
List-Post: <mailto:kgio@librelist.org>
List-Subscribe: <mailto:kgio-subscribe@librelist.com>
List-Unsubscribe: <mailto:kgio-unsubscribe@librelist.com>
Precedence: list
Original-Sender: kgio@librelist.org
Xref: news.gmane.org gmane.comp.lang.ruby.kgio.general:271
Archived-At:
 <http://permalink.gmane.org/gmane.comp.lang.ruby.kgio.general/271>
Received: from zedshaw2.xen.prgmr.com ([71.19.156.177]) by plane.gmane.org
 with esmtp (Exim 4.69) (envelope-from <kgio@librelist.org>) id
 1WY0VS-0003bi-N7 for gclrkg-kgio@m.gmane.org; Wed, 09 Apr 2014 23:58:06 +0200
Received: from zedshaw2.xen.prgmr.com (unknown [IPv6:::1]) by
 zedshaw2.xen.prgmr.com (Postfix) with ESMTP id 19FD475091 for
 <gclrkg-kgio@m.gmane.org>; Wed,  9 Apr 2014 22:00:09 +0000 (UTC)

penultimate return value may be a subarray for writev-related
routines, not a string.

Caught by a pre-upload check by Christian Hofstaedtler
on the debian-ruby list for kgio 2.9.1

Tested-by: Christian Hofstaedtler <zeha@debian.org>
Cc: Hleb Valoshka <375gnu@gmail.com>
Cc: <debian-ruby@lists.debian.org>
Cc: Yura Sokolov <funny.falcon@gmail.com>
---
 test/lib_read_write.rb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/lib_read_write.rb b/test/lib_read_write.rb
index cac87b7..26e7aef 100644
--- a/test/lib_read_write.rb
+++ b/test/lib_read_write.rb
@@ -292,7 +292,8 @@ module LibReadWriteTest
     assert_equal :wait_writable, tmp.pop
     assert tmp.size > 0
     penultimate = tmp.pop
-    assert(penultimate == "I" || penultimate == nil)
+    assert(penultimate == ["I"] || penultimate == nil,
+           "penultimate is #{penultimate.inspect}")
     assert tmp.size > 0
     tmp.each { |count| assert_equal nil, count }
   end
-- 
Eric Wong