From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 4C4E620A93 for ; Thu, 29 Dec 2016 07:42:24 +0000 (UTC) From: Eric Wong To: mogilefs-client-public@bogomips.org Subject: [PATCH 2/3] use opt_str_freeze to avoid allocations in a few places Date: Thu, 29 Dec 2016 07:42:14 +0000 Message-Id: <20161229074215.12425-3-e@80x24.org> In-Reply-To: <20161229074215.12425-1-e@80x24.org> References: <20161229074215.12425-1-e@80x24.org> List-Id: None of these are too performance critical, but err on the safe side and avoid allocations whenever possible. --- lib/mogilefs/http_file.rb | 2 +- lib/mogilefs/new_file/stream.rb | 8 ++++---- lib/mogilefs/new_file/writer.rb | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/mogilefs/http_file.rb b/lib/mogilefs/http_file.rb index caf85ca..c7949a5 100644 --- a/lib/mogilefs/http_file.rb +++ b/lib/mogilefs/http_file.rb @@ -143,7 +143,7 @@ def nhp_put(devid, uri) end put = Net::HTTP::Put.new(uri.path) - put["Content-Type"] = "application/octet-stream" + put["Content-Type"] = "application/octet-stream".freeze if md5 = @opts[:content_md5] if md5.respond_to?(:call) md5 = md5.call.strip diff --git a/lib/mogilefs/new_file/stream.rb b/lib/mogilefs/new_file/stream.rb index 71ac591..195b121 100644 --- a/lib/mogilefs/new_file/stream.rb +++ b/lib/mogilefs/new_file/stream.rb @@ -66,7 +66,7 @@ def commit def start_sock(sock, uri) host_with_port = "#{uri.host}:#{uri.port}" headers = "PUT #{uri.request_uri} HTTP/1.1\r\n" \ - "Host: #{host_with_port}\r\n" \ + "Host: #{host_with_port}\r\n" content_md5 = @opts[:content_md5] if String === content_md5 @@ -75,16 +75,16 @@ def start_sock(sock, uri) :trailer == content_md5 || MD5_TRAILER_NODES[host_with_port] @md5 = Digest::MD5.new - headers << "Trailer: Content-MD5\r\n" + headers << "Trailer: Content-MD5\r\n".freeze end if ! @md5 && clen = @opts[:content_length] headers << "Content-Length: #{clen}\r\n" else - headers << "Transfer-Encoding: chunked\r\n" + headers << "Transfer-Encoding: chunked\r\n".freeze end - sock.write(headers << "\r\n") + sock.write(headers << "\r\n".freeze) end alias syswrite write diff --git a/lib/mogilefs/new_file/writer.rb b/lib/mogilefs/new_file/writer.rb index d58a4e6..e2f13fc 100644 --- a/lib/mogilefs/new_file/writer.rb +++ b/lib/mogilefs/new_file/writer.rb @@ -9,7 +9,7 @@ module MogileFS::NewFile::Writer def puts(*args) args.each do |obj| write(obj) - write("\n") + write("\n".freeze) end nil end -- EW