From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.6 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, UNWANTED_LANGUAGE_BODY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 700FD1F4C1 for ; Wed, 30 Oct 2019 09:23:57 +0000 (UTC) From: Eric Wong To: mogilefs-client-public@bogomips.org Subject: [PATCH 1/3] mogilefs: actually use kwarg for Net::HTTP::Persistent.new Date: Wed, 30 Oct 2019 09:23:55 +0000 Message-Id: <20191030092357.30238-2-e@80x24.org> In-Reply-To: <20191030092357.30238-1-e@80x24.org> References: <20191030092357.30238-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Ruby 2.7.0dev will warn about hashes uses as kwargs *sigh* --- lib/mogilefs/mogilefs.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/mogilefs/mogilefs.rb b/lib/mogilefs/mogilefs.rb index 724dfb6..990ae38 100644 --- a/lib/mogilefs/mogilefs.rb +++ b/lib/mogilefs/mogilefs.rb @@ -550,8 +550,11 @@ def file_debug(args) end def nhp_new(name) # :nodoc: - Net::HTTP::Persistent::VERSION.to_f >= 3.0 and name = { :name => name } - MogileFS::NHP.new(name) + if Net::HTTP::Persistent::VERSION.to_f >= 3.0 + MogileFS::NHP.new(:name => name) + else + MogileFS::NHP.new(name) + end rescue NameError MogileFS::NHP.new(name) end