From 76ef95496eb5f38434c28b8080e08b668a8bf4f6 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 29 Jun 2012 20:33:10 +0000 Subject: admin: get_devices casts reject_bad_md5 to boolean This is a boolean value on the server and we always try to make our return values Ruby-friendly --- lib/mogilefs/admin.rb | 6 ++++++ test/fresh.rb | 7 +++++++ 2 files changed, 13 insertions(+) diff --git a/lib/mogilefs/admin.rb b/lib/mogilefs/admin.rb index 2b3540a..06ba2a5 100644 --- a/lib/mogilefs/admin.rb +++ b/lib/mogilefs/admin.rb @@ -69,6 +69,12 @@ class MogileFS::Admin < MogileFS::Client rv.each do |row| u = row["utilization"] and row["utilization"] = nil == u ? nil : u.to_f + case row["reject_bad_md5"] + when "1" + row["reject_bad_md5"] = true + when "0" + row["reject_bad_md5"] = false + end end end diff --git a/test/fresh.rb b/test/fresh.rb index 7ccf3cf..f5eb1f9 100644 --- a/test/fresh.rb +++ b/test/fresh.rb @@ -132,6 +132,13 @@ EOF wait_for_usage_file "dev1" assert_equal true, @admin.create_device("me", 2) wait_for_usage_file "dev2" + + # MogileFS::Server 2.60+ shows reject_bad_md5 monitor status + dev = @admin.get_devices[0] + if dev.include?("reject_bad_md5") + assert_include([true, false], dev["reject_bad_md5"]) + end + out = err = nil tries = 0 begin -- cgit v1.2.3-24-ge0c7