Rainbows! Rack HTTP server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org>
To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
Subject: [PATCH] bump unicorn dependency to 4.6.2+ for Ruby 2.0.0
Date: Tue, 26 Feb 2013 03:19:34 +0000	[thread overview]
Message-ID: <20130226031934.GA26866@dcvr.yhbt.net> (raw)
In-Reply-To: <20130225130619.GA27183-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>

Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> wrote:
> Due to this weird issue in the unicorn chunk parser C extension:
> https://bugs.ruby-lang.org/issues/7957
> I'm pretty sure rb_str_modify() should work...

This was a bug in unicorn fixed in the v4.6.2 release

ref: commit f7ee06592d7709e96f64efb5e7a9485b54415c9d in
     git://bogomips.org/unicorn.git

Rainbows! will depend on 4.6.2+

>From 95d6719722f31987c72052b000f67d99989a81c8 Mon Sep 17 00:00:00 2001
From: Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org>
Date: Tue, 26 Feb 2013 03:16:46 +0000
Subject: [PATCH] bump unicorn dependency to 4.6.2+ for Ruby 2.0.0

This ensures we're compatible with the latest stable
Ruby version.
---
 rainbows.gemspec  | 4 +++-
 t/test_isolate.rb | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/rainbows.gemspec b/rainbows.gemspec
index bcbbf5b..6a906cf 100644
--- a/rainbows.gemspec
+++ b/rainbows.gemspec
@@ -28,7 +28,9 @@ Gem::Specification.new do |s|
   s.add_dependency(%q<kgio>, ['~> 2.5'])
 
   # we need Unicorn for the HTTP parser and process management
-  s.add_dependency(%q<unicorn>, ["~> 4.6"]) # 4.6.0+ supports hijacking
+  # 4.6.0+ supports hijacking, 4.6.2 fixes the chunk parser (for Ruby 2.0.0)
+  s.add_dependency(%q<unicorn>, ["~> 4.6", ">= 4.6.2"])
+
   s.add_development_dependency(%q<isolate>, "~> 3.1")
   s.add_development_dependency(%q<wrongdoc>, "~> 1.6")
 
diff --git a/t/test_isolate.rb b/t/test_isolate.rb
index 6b7fe5a..d5daa8c 100644
--- a/t/test_isolate.rb
+++ b/t/test_isolate.rb
@@ -20,7 +20,7 @@ Isolate.now!(opts) do
   gem 'rack', '1.5.2'
   gem 'kcar', '0.4.0'
   gem 'raindrops', '0.10.0'
-  gem 'unicorn', '4.6.0'
+  gem 'unicorn', '4.6.2'
 
   if engine == "ruby"
     gem 'sendfile', '1.1.0'
-- 
1.8.1.2.526.gf51a757

_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


      parent reply	other threads:[~2013-02-26  3:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-25 13:06 Rainbows! Coolio/XEpoll failing under Ruby 2.0.0-p0 Eric Wong
     [not found] ` <20130225130619.GA27183-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2013-02-26  3:19   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/rainbows/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130226031934.GA26866@dcvr.yhbt.net \
    --to=normalperson-rmlxzr9ms24@public.gmane.org \
    --cc=rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/rainbows.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).