Rainbows! Rack HTTP server user/dev discussion
 help / Atom feed
* [PATCH] Update eventmachine to 1.0.3 which compiles under Ruby 2.0
@ 2013-09-12 16:48 Lin Jen-Shin
       [not found] ` <1379004491-71337-1-git-send-email-godfat-hOE/xeEBYYIdnm+yROfE0A@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Lin Jen-Shin @ 2013-09-12 16:48 UTC (permalink / raw)
  To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw; +Cc: Lin Jen-Shin

---
 t/GNUmakefile     | 10 ++--------
 t/test_isolate.rb |  2 +-
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/t/GNUmakefile b/t/GNUmakefile
index 19aacbe..eaa200a 100644
--- a/t/GNUmakefile
+++ b/t/GNUmakefile
@@ -45,14 +45,8 @@ ifeq ($(RUBY_ENGINE),ruby)
     models += CoolioThreadPool
     models += CoolioThreadSpawn
     models += CoolioFiberSpawn
-
-    # EventMachine 1.0.0 currently does not build on Ruby 2.0.0
-    # NeverBlock depends on 2.0.0
-    RBTWO := $(shell case $(RUBY_VERSION) in 2.0.*$(rp) echo true;;esac)
-    ifeq ($(RBTWO),)
-      models += EventMachine
-      models += NeverBlock
-    endif
+    models += EventMachine
+    models += NeverBlock
   endif
 endif
 
diff --git a/t/test_isolate.rb b/t/test_isolate.rb
index f5f97b1..e86419a 100644
--- a/t/test_isolate.rb
+++ b/t/test_isolate.rb
@@ -26,7 +26,7 @@ Isolate.now!(opts) do
     gem 'sendfile', '1.1.0'
     gem 'cool.io', '1.1.0'
 
-    gem 'eventmachine', '1.0.0'
+    gem 'eventmachine', '1.0.3'
     gem 'sinatra', '1.3.3'
     gem 'async_sinatra', '1.0.0'
 
-- 
1.8.4

_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|threaded] 4+ messages in thread

* Re: [PATCH] Update eventmachine to 1.0.3 which compiles under Ruby 2.0
       [not found] ` <1379004491-71337-1-git-send-email-godfat-hOE/xeEBYYIdnm+yROfE0A@public.gmane.org>
@ 2013-09-13 18:19   ` Eric Wong
       [not found]     ` <20130913181933.GA11118-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Wong @ 2013-09-13 18:19 UTC (permalink / raw)
  To: Rainbows! list; +Cc: Lin Jen-Shin

EM 1.0.3 doesn't seem to work with Cramp.  Can you try? I probably won't
have time to look further for at least a week.

Thanks.
_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|threaded] 4+ messages in thread

* Re: [PATCH] Update eventmachine to 1.0.3 which compiles under Ruby 2.0
       [not found]     ` <20130913181933.GA11118-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
@ 2013-09-13 19:13       ` Lin Jen-Shin (godfat)
       [not found]         ` <CAA2_N1sDC2bJd8kQC+V2_M=UAL2xrUYEjWPS5hWBwmXiN6LM6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Lin Jen-Shin (godfat) @ 2013-09-13 19:13 UTC (permalink / raw)
  To: Eric Wong; +Cc: Rainbows! list

On Sat, Sep 14, 2013 at 2:19 AM, Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> wrote:
> EM 1.0.3 doesn't seem to work with Cramp.  Can you try? I probably won't
> have time to look further for at least a week.
>
> Thanks.

Umm... looks like Cramp doesn't even run smooth on Ruby 2.0 (or even 1.9?)
I just tried EM 1.0.3 with Cramp 0.15.1, there's an encoding issue in:

    t/tmp/isolate/ruby-2.0.0/cramp/gems/cramp-0.15.1/lib/cramp/callbacks.rb:82

Which has an improper regexp:

    /\000([^\377]*)\377/

After adding magic binary encoding on top of the file:

    # encoding: binary

Then all tests in EventMachine.t0500-cramp-streaming.sh and
EventMachine.t0501-cramp-rainsocket.sh passed.

What should we do here? Are people even using Cramp..?
It seems it's not updated for two years already.

Please take your time, thanks!
_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|threaded] 4+ messages in thread

* Cramp support for Ruby 2.0?
       [not found]         ` <CAA2_N1sDC2bJd8kQC+V2_M=UAL2xrUYEjWPS5hWBwmXiN6LM6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2013-09-23 22:44           ` Eric Wong
  0 siblings, 0 replies; 4+ messages in thread
From: Eric Wong @ 2013-09-23 22:44 UTC (permalink / raw)
  To: Pratik Naik; +Cc: Rainbows! list, Lin Jen-Shin \(godfat\)

(Pulling Pratik into the discussion)

Hi Pratik, just wondering if you're still interested in Cramp.

It doesn't seem to work on Ruby 2.0 (see messages below), but if you're
no longer interested, that's totally fine; we'll just point users
elsewhere.  I don't think Cramp ever really took off and EM seems to
be losing traction, too.

"Lin Jen-Shin (godfat)" <godfat-hOE/xeEBYYIdnm+yROfE0A@public.gmane.org> wrote:
> On Sat, Sep 14, 2013 at 2:19 AM, Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> wrote:
> > EM 1.0.3 doesn't seem to work with Cramp.  Can you try? I probably won't
> > have time to look further for at least a week.
> >
> > Thanks.
> 
> Umm... looks like Cramp doesn't even run smooth on Ruby 2.0 (or even 1.9?)
> I just tried EM 1.0.3 with Cramp 0.15.1, there's an encoding issue in:
> 
>     t/tmp/isolate/ruby-2.0.0/cramp/gems/cramp-0.15.1/lib/cramp/callbacks.rb:82
> 
> Which has an improper regexp:
> 
>     /\000([^\377]*)\377/
> 
> After adding magic binary encoding on top of the file:
> 
>     # encoding: binary
> 
> Then all tests in EventMachine.t0500-cramp-streaming.sh and
> EventMachine.t0501-cramp-rainsocket.sh passed.
> 
> What should we do here? Are people even using Cramp..?
> It seems it's not updated for two years already.
> 
> Please take your time, thanks!
_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|threaded] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-12 16:48 [PATCH] Update eventmachine to 1.0.3 which compiles under Ruby 2.0 Lin Jen-Shin
     [not found] ` <1379004491-71337-1-git-send-email-godfat-hOE/xeEBYYIdnm+yROfE0A@public.gmane.org>
2013-09-13 18:19   ` Eric Wong
     [not found]     ` <20130913181933.GA11118-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2013-09-13 19:13       ` Lin Jen-Shin (godfat)
     [not found]         ` <CAA2_N1sDC2bJd8kQC+V2_M=UAL2xrUYEjWPS5hWBwmXiN6LM6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-23 22:44           ` Cramp support for Ruby 2.0? Eric Wong

Rainbows! Rack HTTP server user/dev discussion

Archives are clonable:
	git clone --mirror https://bogomips.org/rainbows-public
	git clone --mirror http://ou63pmih66umazou.onion/rainbows-public

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.rainbows
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.rainbows

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox