Re: [PATCH] Match against newer curl.

[Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org>]

Lin Jen-Shin <godfat-hOE/xeEBYYIdnm+yROfE0A@public.gmane.org> wrote:
> My curl 7.32.0 would actually print 400 Bad Request
> Hope this would make it match against newer or older curl.
> ---
>  t/t0045-client_max_header_size.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/t/t0045-client_max_header_size.sh b/t/t0045-client_max_header_size.sh
> index cd8f1fe..320fe0c 100755
> --- a/t/t0045-client_max_header_size.sh
> +++ b/t/t0045-client_max_header_size.sh
> @@ -60,7 +60,7 @@ t_begin "smallest HTTP/0.9 request works right" && {
>  
>  t_begin "HTTP/1.1 request fails" && {
>  	curl -vsSf http://$listen/ > $tmp 2>&1 && die "unexpected curl success"
> -	grep '400$' $tmp
> +	grep '400\( Bad Request\)\?$' $tmp

I think thse cases should just use "--write-out %{http_code}" instead.
Theres probably a bunch of places where we should be doing this, really.
--write-out has been around for at least 10 years, so I think it's safe
to use.

Also, I notice this got combined into your EventMachineThread* patch.
_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying