From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: * X-Spam-ASN: AS33070 50.56.128.0/17 X-Spam-Status: No, score=1.7 required=3.0 tests=AWL,HK_RANDOM_FROM, MSGID_FROM_MTA_HEADER,RDNS_NONE shortcircuit=no autolearn=no version=3.3.2 Path: news.gmane.org!not-for-mail From: Eric Wong Newsgroups: gmane.comp.lang.ruby.rainbows.general Subject: Re: [PATCH] Match against newer curl. Date: Wed, 25 Sep 2013 01:46:57 +0000 Message-ID: <20130925014657.GA21892@dcvr.yhbt.net> References: <1379004076-69752-1-git-send-email-godfat@godfat.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1380073629 9785 80.91.229.3 (25 Sep 2013 01:47:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Sep 2013 01:47:09 +0000 (UTC) Cc: Lin Jen-Shin To: Rainbows! list Original-X-From: rainbows-talk-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Wed Sep 25 03:47:13 2013 Return-path: Envelope-to: gclrrg-rainbows-talk@m.gmane.org X-Original-To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Delivered-To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Content-Disposition: inline In-Reply-To: <1379004076-69752-1-git-send-email-godfat-hOE/xeEBYYIdnm+yROfE0A@public.gmane.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: rainbows-talk-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Errors-To: rainbows-talk-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org X-Broken-Reverse-DNS: no host name found for IP address 50.56.192.79 Xref: news.gmane.org gmane.comp.lang.ruby.rainbows.general:546 Archived-At: Received: from [50.56.192.79] (helo=rubyforge.org) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VOeC7-0001Eg-92 for gclrrg-rainbows-talk@m.gmane.org; Wed, 25 Sep 2013 03:47:11 +0200 Received: from localhost.localdomain (localhost [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 6A0422E22A; Wed, 25 Sep 2013 01:47:09 +0000 (UTC) Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64]) by rubyforge.org (Postfix) with ESMTP id 5C32B2E223 for ; Wed, 25 Sep 2013 01:46:58 +0000 (UTC) Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E2F861F6FB; Wed, 25 Sep 2013 01:46:57 +0000 (UTC) Lin Jen-Shin wrote: > My curl 7.32.0 would actually print 400 Bad Request > Hope this would make it match against newer or older curl. > --- > t/t0045-client_max_header_size.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t0045-client_max_header_size.sh b/t/t0045-client_max_header_size.sh > index cd8f1fe..320fe0c 100755 > --- a/t/t0045-client_max_header_size.sh > +++ b/t/t0045-client_max_header_size.sh > @@ -60,7 +60,7 @@ t_begin "smallest HTTP/0.9 request works right" && { > > t_begin "HTTP/1.1 request fails" && { > curl -vsSf http://$listen/ > $tmp 2>&1 && die "unexpected curl success" > - grep '400$' $tmp > + grep '400\( Bad Request\)\?$' $tmp I think thse cases should just use "--write-out %{http_code}" instead. Theres probably a bunch of places where we should be doing this, really. --write-out has been around for at least 10 years, so I think it's safe to use. Also, I notice this got combined into your EventMachineThread* patch. _______________________________________________ Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org http://rubyforge.org/mailman/listinfo/rainbows-talk Do not quote signatures (like this one) or top post when replying